Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collection loader builtin handling. #58897

Merged

Conversation

Projects
None yet
3 participants
@mattclay
Copy link
Member

commented Jul 10, 2019

SUMMARY

Fix collection loader builtin handling:

  • Support more import statements:

    from ansible_collections.ansible.builtin.plugins.module_utils import basic
    from ansible_collections.ansible.builtin.plugins.module_utils.basic import AnsibleModule

  • Add unit tests for more import statements.

  • Raise ImportError instead of returning None if load_module fails.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

collection loader

Fix collection loader builtin handling.
- Support more import statements:

  from ansible_collections.ansible.builtin.plugins.module_utils import basic
  from ansible_collections.ansible.builtin.plugins.module_utils.basic import AnsibleModule

- Add unit tests for more import statements.
- Raise ImportError instead of returning None if load_module fails.

@nitzmahone nitzmahone merged commit d4dec59 into ansible:devel Jul 16, 2019

1 check passed

Shippable Run 131522 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.