Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow configurable fail/misisng password matching #58931

Open
wants to merge 6 commits into
base: devel
Choose a base branch
from

Conversation

@bcoca
Copy link
Member

@bcoca bcoca commented Jul 10, 2019

sudo is the start, but should include other plugins

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

become

@ansibot

This comment has been hidden.

@@ -77,12 +77,23 @@ def _check_password_error(self, b_out, msg):
return b_fail and b_fail in b_out

def check_incorrect_password(self, b_output):
try:
self.fail = self.get_option('become_fail_match')
Copy link
Member

@sivel sivel Jul 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we allow regex here? Similar to what we do in doas and su for password prompts?

Loading

Copy link
Member Author

@bcoca bcoca Jul 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guess that would be most flexible

Loading

Copy link
Member Author

@bcoca bcoca Jul 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we already use dgettext to try to get 'untranslated', not sure this will mesh well

Loading

@ansibot

This comment has been hidden.

@ansibot

This comment has been hidden.

@ansibot

This comment has been hidden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants