Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add return_access_keys param to azure_rm_storageaccount_facts #58934

Open

Conversation

Projects
None yet
2 participants
@PascalVA
Copy link

commented Jul 10, 2019

SUMMARY

I have added the param return_access_keys to azure_rm_storageaccount_facts similar to other azure modules (postgres, redis, cosmosdb). I have also changed the method name get_connectionstring to get_acocunt_keys to be more descriptive of what it is actually doing. The function itself has also been updated to return a dict of key-value pairs instead of just a list.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

azure_rm_storageaccount_facts

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

@PascalVA, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_storageaccount_facts.py:0:0: E309 version_added for new option (return_access_keys) should be '2.9'. Currently StrictVersion ('0.0')

click here for bot help

@PascalVA PascalVA force-pushed the PascalVA:azure_rm_storageaccount_facts_return_access_keys branch from d79b9c3 to b7c0280 Jul 11, 2019

@ansibot ansibot removed the ci_verified label Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.