Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
VMware: Support multiple CDROM for Windows #58951
Add support for multi cdrom implementation. This scenario will help enable the use case to create a Windows template on VMware Vcenter from ISO files using Ansible playbook only. In this scenario, first cdrom is windows installation media, second cdrom is an autogenerated iso file that contains Autounattend,xml file to enable automatic installation of Windows without user interaction or other tools. See this galaxy role with this implementation: https://galaxy.ansible.com/oatakan/windows_vcenter_template.
Note that this installation will break backwards compatibility as it moves cdrom attribute from 'dict' to 'list'. Not sure how to implement to allow either for backwards compatibility, suggestions are welcome here to help move this into the project.
This is needed to support the use case to create a Windows template from scratch.
vmware guest.py: add support for multiple cdroms
@Akasurde Thanks for your quick response. I didn't originally see that PR. After reviewing, it accomplishes the same. One thing I'm not sure if that PR is set to be included in 2.9? Can you confirm? If so, we can close this one for sure.
Also for PR #51120, I think there should be default values so that user doesn't have to specify type 'controller_type', 'controller_number' and 'unit_number' so that it can be simpler from end-user perspective. I haven't tested it yet but it also needs to be tested to see if it supports addition/deletion scenarios properly which this PR does currently.