Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: vmware_guest: predictable VM names during test #58954

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
3 participants
@goneri
Copy link
Contributor

commented Jul 11, 2019

SUMMARY
  • Use predictable VM name during the tests (test_vm1, test_vm2 and
    test_vm2). This to simplify the teardown of the newly created resource
    before the next test.
  • Avoid VM creation with with_items when it's not mandatory. This to:
    • speed up the test execution, our hypervisors have limited resources
    • simplify the teardown
  • Remove create_d1_c1_f0_env.yml, the test was just testing how Ansible
    pass environment variables.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

vmware_guest

@goneri goneri changed the title vmware_guest: predictable VM names during test WIP: vmware_guest: predictable VM names during test Jul 11, 2019

@ansibot

This comment has been minimized.

vmware_guest: predictable VM names during test
- Use predictable VM name during the tests (test_vm1, test_vm2 and
  test_vm2). This to simplify the teardown of the newly created resource
  before the next test.
- Avoid VM creation with `with_items` when it's not mandatory. This to:
    - speed up the test execution, our hypervisors have limited resources
    - simplify the teardown
- Remove `create_d1_c1_f0_env.yml`, the test was just testing how Ansible
  pass environment variables.

@goneri goneri force-pushed the goneri:vmware_test_vm_names branch from 4d7565c to 4c59fc6 Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.