Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules to manage ICX devices #58969

Merged
merged 25 commits into from Jul 31, 2019

Conversation

@sushma-alethea
Copy link
Contributor

commented Jul 11, 2019

SUMMARY
Running command to manage ICX device by Ansible automatically.

ISSUE TYPE
New Module Pull Request

COMPONENT NAME
ICX_7150

ADDITIONAL INFORMATION
Achieving of running command to manage ICX device by Ansible automatically.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

@sushma-alethea, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

The test ansible-test sanity --test no-main-display [explain] failed with 1 error:

lib/ansible/plugins/terminal/icx.py:32:7: Display is a singleton, just import and instantiate

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:28:0: ansible-bad-import-from Import Mapping from ansible.module_utils.common._collections_compat instead of collections

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

click here for bot help

@ansibot ansibot added ci_verified and removed ci_verified labels Jul 11, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 19, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with the error:

Command "ansible-doc -t module icx_banner" returned exit status 250.
>>> Standard Error
ERROR! Unexpected Exception, this is probably a bug: pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with the error:

Command "ansible-doc -t module icx_banner" returned exit status 250.
>>> Standard Error
ERROR! Unexpected Exception, this is probably a bug: pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with the error:

Command "ansible-doc -t module icx_banner" returned exit status 250.
>>> Standard Error
ERROR! Unexpected Exception, this is probably a bug: pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with the error:

Command "ansible-doc -t module icx_banner" returned exit status 250.
>>> Standard Error
ERROR! Unexpected Exception, this is probably a bug: pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with the error:

Command "ansible-doc -t module icx_banner" returned exit status 250.
>>> Standard Error
ERROR! Unexpected Exception, this is probably a bug: pop() takes at most 1 argument (2 given)

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with the error:

Command "ansible-doc -t module icx_banner" returned exit status 250.
>>> Standard Error
ERROR! Unexpected Exception, this is probably a bug: pop expected at most 1 argument, got 2

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-config --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../../hacking/build-ansible.py generate-man --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-keywords --template-dir=../templates --output-dir=rst/reference_appendices/ ./keyword_desc.yml
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-plugins -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:93: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../../hacking/build-ansible.py", line 88, in <module>
    main()
  File "../../hacking/build-ansible.py", line 79, in main
    retval = command.main(args)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 775, in main
    plugin_info, categories = get_plugin_info(args.module_dir, limit_to=args.limit_to, verbose=(args.verbosity > 0))
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 344, in get_plugin_info
    doc['options'][key] = normalize_options(opt)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 175, in normalize_options
    if value.get('type') == 'bool' and 'default' in value:
AttributeError: 'AnsibleSequence' object has no attribute 'get'
make: *** [modules] Error 1

click here for bot help

shashik added some commits Jul 19, 2019

shashik
shashik
shashik
shashik
shashik
shashik
shashik
@sushma-alethea

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

Ansible team can you please review and merge to devel.

@justjais justjais requested a review from Akasurde Jul 24, 2019

shashik
@Akasurde

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

@samccann @acozine Could you please take a look for documentation changes ? Rest LGTM.

docs/docsite/rst/network/user_guide/platform_icx.rst Outdated Show resolved Hide resolved
lib/ansible/plugins/cliconf/icx.py Outdated Show resolved Hide resolved
lib/ansible/plugins/cliconf/icx.py Outdated Show resolved Hide resolved
shashik
Update platform_index.rst
PR comment resolved
@ganeshrn
Copy link
Member

left a comment

As per convention generally, network os name is used for network modules within Ansible (there are some exceptions to this). If the modules in the PR are applicable for other Ruckus device series other than ICX it is recommended to rename it after the os name.
ansible_network_os value, in this case, will be icx

Other than that the code changes in PR look good to me.

@sushma-alethea

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

@ganeshrn, modules in this PR and all subsequent PRs that we will be rasing are applicable only for Ruckus ICX series devices. So, ansible_network_is name which we have set to icx is fine.
Can you please now merge the PR to devel.

@samccann
Copy link
Contributor

left a comment

docs portion LGTM

@ganeshrn

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

@sushma-alethea Thank you for the contribution
@LindsayHill @samccann @Akasurde Thank you for your reviews

@ganeshrn ganeshrn merged commit f2cb446 into ansible:devel Jul 31, 2019

1 check passed

Shippable Run 133837 status is SUCCESS.
Details

reflop added a commit to reflop/ansible that referenced this pull request Aug 2, 2019

Modules to manage ICX devices (ansible#58969)
* new module

* new terminal

* new terminal

* new cliconf

* cliconf

* icx cliconf

* icx_cliconf

* icx test units module

* icx units module

* icx banner unit test

* PR changes resolved

* changes resolved

* Changes Resolved

* check_running_config changes resolved

* added notes

* removed icx rst

* new commit

* new changes

* deleted icx rst

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved

nkatarmal-crest added a commit to ciscoecosystem/ansible that referenced this pull request Aug 22, 2019

Modules to manage ICX devices (ansible#58969)
* new module

* new terminal

* new terminal

* new cliconf

* cliconf

* icx cliconf

* icx_cliconf

* icx test units module

* icx units module

* icx banner unit test

* PR changes resolved

* changes resolved

* Changes Resolved

* check_running_config changes resolved

* added notes

* removed icx rst

* new commit

* new changes

* deleted icx rst

* icx .rst

* modified platform_index.rst

* modified platform_index.rst

* changes resolved

* PR comments resolved

* Update platform_index.rst

PR comment resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.