Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules to manage ICX devices #58969

Open
wants to merge 13 commits into
base: devel
from

Conversation

Projects
None yet
5 participants
@sushma-alethea
Copy link

commented Jul 11, 2019

SUMMARY
Running command to manage ICX device by Ansible automatically.

ISSUE TYPE
New Module Pull Request

COMPONENT NAME
ICX_7150

ADDITIONAL INFORMATION
Achieving of running command to manage ICX device by Ansible automatically.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

@sushma-alethea, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

The test ansible-test sanity --test no-main-display [explain] failed with 1 error:

lib/ansible/plugins/terminal/icx.py:32:7: Display is a singleton, just import and instantiate

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:28:0: ansible-bad-import-from Import Mapping from ansible.module_utils.common._collections_compat instead of collections

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

The test ansible-test sanity --test ansible-doc --python 2.6 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 2.7 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.5 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.6 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.7 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

The test ansible-test sanity --test ansible-doc --python 3.8 [explain] failed with 1 error:

lib/ansible/plugins/cliconf/icx.py:0:0: missing documentation (or could not parse documentation): 'NoneType' object does not support item assignment

click here for bot help

@ansibot ansibot added ci_verified and removed ci_verified labels Jul 11, 2019

shashik added some commits Jul 11, 2019

@sushma-alethea sushma-alethea force-pushed the sushma-alethea:devel branch from 2bc08b9 to fc424da Jul 11, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

@sushma-alethea This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

shashik and others added some commits Jul 11, 2019

shashik
Abhishek Kumar Roy Abhishek Kumar Roy
@ansibot

This comment has been minimized.

@Akasurde Akasurde changed the title new module Modules to manage ICX devices Jul 12, 2019

@Akasurde
Copy link
Member

left a comment

@sushma-alethea Thanks for the contribution. Could you please review this @ganeshrn @justjais @NilashishC ? Thanks in advance.

Show resolved Hide resolved lib/ansible/module_utils/network/icx/icx.py Outdated
Show resolved Hide resolved lib/ansible/plugins/cliconf/icx.py Outdated
Show resolved Hide resolved lib/ansible/plugins/cliconf/icx.py Outdated
Show resolved Hide resolved lib/ansible/plugins/cliconf/icx.py Outdated
Show resolved Hide resolved lib/ansible/plugins/cliconf/icx.py Outdated
Show resolved Hide resolved lib/ansible/plugins/terminal/icx.py Outdated
Show resolved Hide resolved test/units/modules/network/icx/icx_module.py Outdated
Show resolved Hide resolved test/units/modules/network/icx/test_icx_banner.py Outdated

@Akasurde Akasurde referenced this pull request Jul 12, 2019

Closed

module utils #58964

shashik added some commits Jul 12, 2019

shashik
shashik
@Akasurde

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

@sushma-alethea Thanks for updating PR as per review comments. From myside changes looks good, but I would like to request review from Ansible Networking since this module space is maintained by them. You can join slack channel ansiblenetwork.slack.com and ask for further reviews. Thanks.

@sushma-alethea

This comment has been minimized.

Copy link
Author

commented Jul 16, 2019

the require-enter-key
type: bool
default: no
check_running_config:

This comment has been minimized.

Copy link
@ganeshrn

ganeshrn Jul 17, 2019

Member

What is the purpose of this option? Also if you want option value to fall back on environment variable it can be defined in the argspec as

'check_running_config': dict(default=True, type='bool', fallback=(env_fallback, ['ANSIBLE_CHECK_RUNNING_CONFIG']))

This comment has been minimized.

Copy link
@sushma-alethea

sushma-alethea Jul 17, 2019

Author

User should be able to specify if he/she wants ICX modules to send commands, after checking the running config on switch or without checking. User should be able to specify this at a global level and be able to override it at module level. Basically it is similar to check_mode.

Will the change that you have recommended achieve this?

Can you please tell me how to get myself invited to get added to ansible-network.slack channel

This comment has been minimized.

Copy link
@ganeshrn

ganeshrn Jul 17, 2019

Member

So basically if this option is enabled it will not compare the running-config with candidate config but will directly push the commands to the remote host. If that's the case I don't see a reason for it to be an environment variable.

Can you please tell me how to get myself invited to get added to ansible-network.slack channel

Can you please share me your mail-id. You can unicast it to me on IRC.

My IRC nick is @ganeshrn

This comment has been minimized.

Copy link
@ganeshrn

ganeshrn Jul 17, 2019

Member

You use the link here https://github.com/ansible/community/wiki/Network to join the ansiblenetwork slack channel

This comment has been minimized.

Copy link
@sushma-alethea

sushma-alethea Jul 17, 2019

Author

thanks for the links. About check_running_config, if not environment variable how else can we achieve the same?

shashik
@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

@IPvSean Do you mind sharing instructions on how to register to slack

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

Actually, I am told https://github.com/ansible/community/wiki/Network#contact should be helpful here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.