Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.8] nmcli: Argument vlanid (int) is changed internally to string #58974

Merged
merged 1 commit into from Jul 17, 2019

Conversation

Projects
None yet
4 participants
@pratikgadiya12
Copy link
Contributor

commented Jul 11, 2019

SUMMARY
  • Argument vlanid (int) is changed internally to string
  • Modified test case to check vlan id

Fixes: #58949
(cherry picked from commit e8f4ebb)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/net_tools/nmcli.py

nmcli: Argument vlanid (int) is changed internally to string (#58963)
* Argument vlanid (int) is changed internally to string
* Modified test case to check vlan id

Fixes: #58949
(cherry picked from commit e8f4ebb)
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

@Akasurde Akasurde changed the title nmcli: Argument vlanid (int) is changed internally to string (#58963) nmcli: Argument vlanid (int) is changed internally to string Jul 11, 2019

@Akasurde Akasurde changed the title nmcli: Argument vlanid (int) is changed internally to string [2.8] nmcli: Argument vlanid (int) is changed internally to string Jul 11, 2019

@Akasurde Akasurde removed the needs_triage label Jul 11, 2019

@Akasurde
Copy link
Member

left a comment

LGTM

@abadger abadger merged commit 0f292cd into ansible:stable-2.8 Jul 17, 2019

1 check passed

Shippable Run 131662 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Jul 17, 2019

Merged for the 2.8.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.