Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle draining state when registering in elb_target. Fixes #44149 #58995

Open
wants to merge 1 commit into
base: devel
from

Conversation

Projects
None yet
2 participants
@chevett
Copy link

commented Jul 11, 2019

SUMMARY

elb_target can fail to register a target if it is already draining. Fixes #44149

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

elb_target

ADDITIONAL INFORMATION

If the target was already draining then the de-registration process is already started. The target needs to be registered again if in this state. The issue is described thoroughly in this comment: #44149 (comment)

ok: [192.168.1.2 -> localhost] => {"changed": false, "target_group_arn": "xxx", "target_health_descriptions": {"health_check_port": "80", "target": {"id": "i-xxx", "port": 80}, "target_health": {"description": "Target deregistration is in progress", "reason": "Target.DeregistrationInProgress", "state": "draining"}}}
*************
changed: [192.168.1.2 -> localhost] => {"changed": true, "target_group_arn": "xxx", "target_health_descriptions": {"health_check_port": "80", "target": {"id": "i-xxx", "port": 80}, "target_health": {"state": "healthy"}}}

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/elb_target.py:280:121: undefined-variable Undefined variable 'health_state'

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/elb_target.py:282:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/amazon/elb_target.py:287:1: E302 expected 2 blank lines, found 1

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

@chevett, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/modules/cloud/amazon/elb_target.py:283:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/amazon/elb_target.py:287:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/amazon/elb_target.py:290:1: E302 expected 2 blank lines, found 1
lib/ansible/modules/cloud/amazon/elb_target.py:293:1: E302 expected 2 blank lines, found 1

click here for bot help

@ansibot ansibot added the ci_verified label Jul 11, 2019

@chevett chevett force-pushed the chevett:fix-drain branch from 135ae10 to 4a5cf67 Jul 11, 2019

@ansibot ansibot removed the ci_verified label Jul 11, 2019

@chevett chevett force-pushed the chevett:fix-drain branch from 4a5cf67 to c81d70e Jul 12, 2019

@ansibot ansibot added the stale_ci label Jul 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.