Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use comprehensions rather than map() in container_to_bytes() and container_to_text() #58997

Merged
merged 1 commit into from Jul 12, 2019

Conversation

Projects
None yet
4 participants
@samdoran
Copy link
Member

commented Jul 11, 2019

SUMMARY

Since we now require Python > 2.6 on the controller, we can drop the use of map() here

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/module_utils/common/text/converters.py

Use comprehensions rather than map()
Since we now require Python > 2.6 on the controller, we can drop the use of map() here
@abadger

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

+1. Note that eventually we'll have to replace this with an iterative version instead of recursive. (because recursion can go too deep). Don't have to worry about it for now because we haven't had any bugs opened on this code.

@samdoran samdoran merged commit dd30d86 into ansible:devel Jul 12, 2019

1 check passed

Shippable Run 131905 status is SUCCESS.
Details

@samdoran samdoran deleted the samdoran:map-to-comprehensions branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.