Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close file after using it #59000

Merged
merged 1 commit into from Jul 16, 2019

Conversation

Projects
None yet
6 participants
@ekohl
Copy link
Contributor

commented Jul 11, 2019

SUMMARY

It's good to close files to avoid leaking file descriptors. Related to #33655.

ISSUE TYPE
  • Bugfix Pull Request
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

@ekohl: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@bcoca

bcoca approved these changes Jul 12, 2019

@jimi-c

jimi-c approved these changes Jul 16, 2019

@jimi-c jimi-c merged commit 9c5b340 into ansible:devel Jul 16, 2019

1 check passed

Shippable Run 131890 status is SUCCESS.
Details

@ekohl ekohl deleted the ekohl:close-file branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.