Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of Sphinx 2.1.2 errors #59001

Merged
merged 1 commit into from Jul 12, 2019

Conversation

Projects
None yet
6 participants
@acozine
Copy link
Contributor

commented Jul 11, 2019

SUMMARY

Fixes #57709

Currently we pin the docs build to Sphinx 1.x. This PR makes all the changes necessary to run a clean make webdocs using Sphinx 2.1.2 on Python 3.7.3.

Takes the same approach to fixing the PowerShell lexer concerns as https://github.com/ansible/ansible/pull/57508/files#diff-1653c8c6462362632397ce0e9c948610R405.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs.ansible.com

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

@felixfontein
Copy link
Contributor

left a comment

Most of these code blocks currently look pretty ugly anyway, due to all the lexing error marks, see for example https://docs.ansible.com/ansible/devel/user_guide/windows_setup#delete-winrm-listener So lexing them with YAML+Jinja (which this PR probably does, since that's the default lexer IIRC) can't make it look worse :) For the long term, it might be better to fix the PowerShell lexer so that it accepts colons.

@samccann samccann merged commit 0dd3fb8 into ansible:devel Jul 12, 2019

1 check passed

Shippable Run 131796 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.