Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update azure_rm_virtualnetwork related document #59023

Merged
merged 4 commits into from Jul 16, 2019

Conversation

Projects
None yet
3 participants
@Fred-sun
Copy link
Contributor

commented Jul 12, 2019

SUMMARY

Update azure_rm_virtualnetwork related document.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

azure_rm_virtualnetwork/azure_rm_virtualnetwork_facts/azure_rm_virtualnetworkgateway

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

@Fred-sun, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/cloud/azure/azure_rm_virtualnetwork.py:136:161: E501 line too long (164 > 160 characters)
lib/ansible/modules/cloud/azure/azure_rm_virtualnetwork_facts.py:145:161: E501 line too long (191 > 160 characters)

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_virtualnetwork.py:0:0: E319 RETURN.state.type: not a valid value for dictionary value @ data['state']['type']. Got 'sample'

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_virtualnetwork.py:0:0: E319 RETURN.state.type: not a valid value for dictionary value @ data['state']['type']. Got 'sample'

click here for bot help

@acozine
Copy link
Contributor

left a comment

Thanks @Fred-sun. I found a few improvements to suggest.

@acozine acozine removed the needs_triage label Jul 15, 2019

@acozine

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

Looks good, thanks @Fred-sun.

@acozine acozine merged commit 65e0f37 into ansible:devel Jul 16, 2019

1 check passed

Shippable Run 132244 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.