Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update auzre_rm_virtualnetworkpeering related document #59025

Merged
merged 3 commits into from Jul 16, 2019

Conversation

Projects
None yet
3 participants
@Fred-sun
Copy link
Contributor

commented Jul 12, 2019

SUMMARY

Update auzre_rm_virtualnetworkpeering related document.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

azure_rm_virtualnetworkpeering/azure_rm_virtualnetworkpeering_facts

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkpeering_facts.py:61:13: E313 RETURN is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/cloud/azure/azure_rm_virtualnetworkpeering_facts.py:61:13: error RETURN: syntax error: mapping values are not allowed here

click here for bot help

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

@Fred-sun, just so you are aware we have a dedicated Working Group for azure.
You can find other people interested in this in #ansible-azure on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@Fred-sun

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

ready_for_review

@acozine
Copy link
Contributor

left a comment

Thanks @Fred-sun. Overall looks good, I added some comments to promote consistent wording (if vs. whether, status vs. state).

@acozine acozine removed the needs_triage label Jul 15, 2019

@acozine

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

Thanks @Fred-sun!

@acozine acozine merged commit c738754 into ansible:devel Jul 16, 2019

1 check passed

Shippable Run 132242 status is SUCCESS.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.