Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nxos_lag_interfaces resource module #59031

Open
wants to merge 6 commits into
base: devel
from

Conversation

@trishnaguha
Copy link
Member

commented Jul 12, 2019

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY
ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

modules/network/nxos/nxos_lag_interfaces.py

@ansibot

This comment has been minimized.

Add nxos_lag_interfaces resource module
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

@trishnaguha trishnaguha force-pushed the trishnaguha:nxos_lag_interfacs branch from 16c082a to ac1b95c Jul 15, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

@trishnaguha trishnaguha force-pushed the trishnaguha:nxos_lag_interfacs branch from ac1b95c to 1ea8f47 Jul 15, 2019

ix CI failure
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

@trishnaguha trishnaguha force-pushed the trishnaguha:nxos_lag_interfacs branch from 1ea8f47 to 728eded Jul 15, 2019

module_utils nxos transport-provider fix
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

@ansible ansible deleted a comment from ansibot Jul 15, 2019

@ansible ansible deleted a comment from ansibot Jul 15, 2019

@ansible ansible deleted a comment from ansibot Jul 15, 2019

@ansible ansible deleted a comment from ansibot Jul 15, 2019

@ansible ansible deleted a comment from ansibot Jul 15, 2019

@ansible ansible deleted a comment from ansibot Jul 15, 2019

@trishnaguha trishnaguha force-pushed the trishnaguha:nxos_lag_interfacs branch from 850f629 to bcc1027 Jul 15, 2019

@ansible ansible deleted a comment from ansibot Jul 15, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

@ansibot ansibot added the test label Jul 15, 2019

@trishnaguha trishnaguha force-pushed the trishnaguha:nxos_lag_interfacs branch from bcc1027 to 0fc78a5 Jul 15, 2019

CI failure
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

@trishnaguha trishnaguha force-pushed the trishnaguha:nxos_lag_interfacs branch from 0fc78a5 to d5fcd6c Jul 15, 2019

@ansible ansible deleted a comment from ansibot Jul 15, 2019

nxos_lag_interfaces tests
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

@trishnaguha trishnaguha changed the title [WIP] Add nxos_lag_interfaces resource module Add nxos_lag_interfaces resource module Jul 15, 2019

@ansibot ansibot added core_review and removed WIP labels Jul 15, 2019

@trishnaguha trishnaguha force-pushed the trishnaguha:nxos_lag_interfacs branch from 3af5eda to 09d9a91 Jul 15, 2019

@samccann
Copy link
Contributor

left a comment

docs portion LGTM

@mikewiebe

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

@trishnaguha Did you consider using cmdref for this module? My concern longer term is that as we start to use RMB for new modules we still have to handle platform differences for NX-OS platforms. This module might be simple enough where platform differences are minimal but if we take this module and validate it against N3K, N6k, N7k, N9k (various chassis and versions) we will have to build diff logic inline. CmdRef was designed represent all of the platform commands and differences in a single place. Not saying we need to change this module but we should have the discussion.

@trishnaguha trishnaguha force-pushed the trishnaguha:nxos_lag_interfacs branch from 09d9a91 to a84dbc6 Jul 22, 2019

@ansibot ansibot added core_review and removed shipit labels Jul 22, 2019

Integration test
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

@trishnaguha trishnaguha force-pushed the trishnaguha:nxos_lag_interfacs branch from a84dbc6 to b909787 Jul 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.