Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Speed up VariableManager by preserving Templar state. (#45572)" #59280

Merged
merged 3 commits into from Jul 22, 2019
Merged

Revert "Speed up VariableManager by preserving Templar state. (#45572)" #59280

merged 3 commits into from Jul 22, 2019

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Jul 19, 2019

SUMMARY

This reverts commit 6069d09.

Fixes #57351
Also see #57351 (comment)

This should be backported to 2.8 once merged.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/vars/manager.py

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 19, 2019
@bcoca
Copy link
Member

bcoca commented Jul 19, 2019

do we want to also add #57351 (comment) as a test to avoid future changes from triggering this again?

@mkrizek
Copy link
Contributor Author

mkrizek commented Jul 19, 2019

do we want to also add #57351 (comment) as a test to avoid future changes from triggering this again?

Good idea, test added.

@ansibot ansibot added files Files category and removed needs_triage Needs a first human triage before being processed. labels Jul 19, 2019
@mkrizek mkrizek merged commit b786852 into ansible:devel Jul 22, 2019
@mkrizek mkrizek deleted the revert-45572 branch July 22, 2019 08:27
mkrizek added a commit to mkrizek/ansible that referenced this pull request Jul 22, 2019
@mkrizek
Revert "Speed up VariableManager by preserving Templar state. (ansibl…
cc735af 
…e#45572)" (ansible#59280)

This reverts commit 6069d09.

Fixes ansible#57351

(cherry picked from commit b786852)
mkrizek added a commit to mkrizek/ansible that referenced this pull request Jul 22, 2019
@mkrizek
Add changelog for ansible#59280
13e1c4c
mkrizek added a commit to mkrizek/ansible that referenced this pull request Jul 22, 2019
@mkrizek
Add changelog for ansible#59280 (ansible#59380)
8e0f998 
(cherry picked from commit d6b1376)
StephenSorriaux pushed a commit to StephenSorriaux/ansible that referenced this pull request Jul 22, 2019
@mkrizek
Add changelog for ansible#59280 (ansible#59380)
d6b1376
abadger pushed a commit that referenced this pull request Jul 23, 2019
@mkrizek @abadger
2.8: Revert "Speed up VariableManager by preserving Templar state. (#…
89d5830 
…45572)" (#59280) (#59373)

* Revert "Speed up VariableManager by preserving Templar state. (#45572)" (#59280)

This reverts commit 6069d09.

Fixes #57351

(cherry picked from commit b786852)

* Add changelog for #59280 (#59380)


(cherry picked from commit d6b1376)
@mkrizek mkrizek mentioned this pull request Jul 26, 2019
Merged
@ansible ansible locked and limited conversation to collaborators Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca approved these changes

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. files Files category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression when moving to ansible 2.8 when including a role that has a custom filter
3 participants
@mkrizek @bcoca @ansibot