Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource module for ios_lacp_interfaces #59516

Merged
merged 9 commits into from Aug 20, 2019

Conversation

@justjais
Copy link
Contributor

commented Jul 24, 2019

SUMMARY

Resource module for ios_lacp_interfaces, with supported operations and respective integration tests.
(ref model: ansible-network/resource_module_models#33)

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

ios_lacp_interfaces

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/config/lacp_interfaces/lacp_interfaces.py:246:18: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/config/lacp_interfaces/lacp_interfaces.py:241:39: SyntaxError: want_dict = set(tuple({k: v for k, v in iteritems(want) if v is not None}.items()))

The test ansible-test sanity --test import --python 2.6 [explain] failed with 2 errors:

lib/ansible/module_utils/network/ios/config/lacp_interfaces/lacp_interfaces.py:241:39: SyntaxError: invalid syntax
lib/ansible/modules/network/ios/ios_lacp_interfaces.py:317:0: SyntaxError: invalid syntax (lacp_interfaces.py, line 241)

The test ansible-test sanity --test shebang [explain] failed with 3 errors:

lib/ansible/module_utils/network/ios/argspec/facts/facts.py:0:0: should not have a shebang
lib/ansible/module_utils/network/ios/argspec/lacp_interfaces/lacp_interfaces.py:0:0: should not have a shebang
lib/ansible/module_utils/network/ios/utils/utils.py:0:0: should not have a shebang

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/network/ios/ios_lacp_interfaces.py:0:0: E305 DOCUMENTATION.options.config.elements: extra keys not allowed @ data['options']['config']['elements']. Got 'dict'
lib/ansible/modules/network/ios/ios_lacp_interfaces.py:0:0: E319 RETURN.after.type: required key not provided @ data['after']['type']. Got None
lib/ansible/modules/network/ios/ios_lacp_interfaces.py:0:0: E319 RETURN.before.type: required key not provided @ data['before']['type']. Got None
lib/ansible/modules/network/ios/ios_lacp_interfaces.py:99:57: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/network/ios/ios_lacp_interfaces.py:99:57: error EXAMPLES: syntax error: mapping values are not allowed here

click here for bot help

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/config/lacp_interfaces/lacp_interfaces.py:246:18: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/config/lacp_interfaces/lacp_interfaces.py:241:39: SyntaxError: want_dict = set(tuple({k: v for k, v in iteritems(want) if v is not None}.items()))

The test ansible-test sanity --test import --python 2.6 [explain] failed with 2 errors:

lib/ansible/module_utils/network/ios/config/lacp_interfaces/lacp_interfaces.py:241:39: SyntaxError: invalid syntax
lib/ansible/modules/network/ios/ios_lacp_interfaces.py:317:0: SyntaxError: invalid syntax (lacp_interfaces.py, line 241)

The test ansible-test sanity --test shebang [explain] failed with 3 errors:

lib/ansible/module_utils/network/ios/argspec/facts/facts.py:0:0: should not have a shebang
lib/ansible/module_utils/network/ios/argspec/lacp_interfaces/lacp_interfaces.py:0:0: should not have a shebang
lib/ansible/module_utils/network/ios/utils/utils.py:0:0: should not have a shebang

The test ansible-test sanity --test validate-modules [explain] failed with 4 errors:

lib/ansible/modules/network/ios/ios_lacp_interfaces.py:0:0: E305 DOCUMENTATION.options.config.elements: extra keys not allowed @ data['options']['config']['elements']. Got 'dict'
lib/ansible/modules/network/ios/ios_lacp_interfaces.py:0:0: E319 RETURN.after.type: required key not provided @ data['after']['type']. Got None
lib/ansible/modules/network/ios/ios_lacp_interfaces.py:0:0: E319 RETURN.before.type: required key not provided @ data['before']['type']. Got None
lib/ansible/modules/network/ios/ios_lacp_interfaces.py:99:57: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/network/ios/ios_lacp_interfaces.py:99:57: error EXAMPLES: syntax error: mapping values are not allowed here

click here for bot help

@ansibot

This comment has been minimized.

...nsible/module_utils/network/ios/facts/lacp_interfaces/lacp_interfaces.py Outdated Show resolved Hide resolved
lib/ansible/modules/network/ios/ios_lacp_interfaces.py Outdated Show resolved Hide resolved
...sible/module_utils/network/ios/config/lacp_interfaces/lacp_interfaces.py Outdated Show resolved Hide resolved

@ansibot ansibot removed the needs_triage label Jul 24, 2019

@ansible-zuul

This comment has been minimized.

Copy link

commented Jul 24, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@justjais justjais added this to Module in Review in Ansible 2.9 Networking Feature Dev Jul 24, 2019

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

recheck

@ansible-zuul

This comment has been minimized.

Copy link

commented Jul 24, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@justjais justjais requested a review from NilashishC Jul 24, 2019

@justjais

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

recheck

1 similar comment
@justjais

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

recheck

@ansibot ansibot removed the ci_verified label Jul 24, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/config/lacp_interfaces/lacp_interfaces.py:234:18: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/config/lacp_interfaces/lacp_interfaces.py:229:39: SyntaxError: want_dict = set(tuple({k: v for k, v in iteritems(want) if v is not None}.items()))

The test ansible-test sanity --test import --python 2.6 [explain] failed with 2 errors:

lib/ansible/module_utils/network/ios/config/lacp_interfaces/lacp_interfaces.py:229:39: SyntaxError: invalid syntax
lib/ansible/modules/network/ios/ios_lacp_interfaces.py:320:0: SyntaxError: invalid syntax (lacp_interfaces.py, line 229)

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/module_utils/network/ios/argspec/facts/facts.py:2:1: E265 block comment should start with '# '
lib/ansible/module_utils/network/ios/argspec/lacp_interfaces/lacp_interfaces.py:2:1: E265 block comment should start with '# '
lib/ansible/module_utils/network/ios/utils/utils.py:2:1: E265 block comment should start with '# '
lib/ansible/modules/network/ios/ios_lacp_interfaces.py:2:1: E265 block comment should start with '# '

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/network/ios/ios_lacp_interfaces.py:0:0: E101 Interpreter line is not "#!/usr/bin/python"
lib/ansible/modules/network/ios/ios_lacp_interfaces.py:0:0: E305 DOCUMENTATION.options.config.elements: extra keys not allowed @ data['options']['config']['elements']. Got 'dict'
lib/ansible/modules/network/ios/ios_lacp_interfaces.py:142:67: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/network/ios/ios_lacp_interfaces.py:142:67: error EXAMPLES: syntax error: mapping values are not allowed here

click here for bot help

@ansibot ansibot added the ci_verified label Jul 24, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/config/lacp_interfaces/lacp_interfaces.py:234:18: ansible-format-automatic-specification Format string contains automatic field numbering specification

The test ansible-test sanity --test compile --python 2.6 [explain] failed with 1 error:

lib/ansible/module_utils/network/ios/config/lacp_interfaces/lacp_interfaces.py:229:39: SyntaxError: want_dict = set(tuple({k: v for k, v in iteritems(want) if v is not None}.items()))

The test ansible-test sanity --test import --python 2.6 [explain] failed with 2 errors:

lib/ansible/module_utils/network/ios/config/lacp_interfaces/lacp_interfaces.py:229:39: SyntaxError: invalid syntax
lib/ansible/modules/network/ios/ios_lacp_interfaces.py:320:0: SyntaxError: invalid syntax (lacp_interfaces.py, line 229)

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/module_utils/network/ios/argspec/facts/facts.py:2:1: E265 block comment should start with '# '
lib/ansible/module_utils/network/ios/argspec/lacp_interfaces/lacp_interfaces.py:2:1: E265 block comment should start with '# '
lib/ansible/module_utils/network/ios/utils/utils.py:2:1: E265 block comment should start with '# '
lib/ansible/modules/network/ios/ios_lacp_interfaces.py:2:1: E265 block comment should start with '# '

The test ansible-test sanity --test validate-modules [explain] failed with 3 errors:

lib/ansible/modules/network/ios/ios_lacp_interfaces.py:0:0: E101 Interpreter line is not "#!/usr/bin/python"
lib/ansible/modules/network/ios/ios_lacp_interfaces.py:0:0: E305 DOCUMENTATION.options.config.elements: extra keys not allowed @ data['options']['config']['elements']. Got 'dict'
lib/ansible/modules/network/ios/ios_lacp_interfaces.py:142:67: E311 EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

lib/ansible/modules/network/ios/ios_lacp_interfaces.py:142:67: error EXAMPLES: syntax error: mapping values are not allowed here

click here for bot help

@ansibot ansibot added core_review and removed needs_revision labels Aug 19, 2019

@ansible-zuul

This comment has been minimized.

Copy link

commented Aug 19, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@ansible-zuul

This comment has been minimized.

Copy link

commented Aug 19, 2019

Build succeeded (third-party-check pipeline).

@ansible-zuul

This comment has been minimized.

Copy link

commented Aug 20, 2019

Build succeeded (third-party-check pipeline).

@ansibot ansibot added needs_revision and removed core_review labels Aug 20, 2019

@justjais justjais force-pushed the justjais:ios_lacp_interfaces branch to 98421e7 Aug 20, 2019

@ansibot ansibot added core_review and removed needs_revision labels Aug 20, 2019

@ansible-zuul

This comment has been minimized.

Copy link

commented Aug 20, 2019

Build succeeded (third-party-check pipeline).

@justjais justjais merged commit 8a8798c into ansible:devel Aug 20, 2019

2 checks passed

Shippable Run 138314 status is SUCCESS.
Details
ansible/third-party-check third-party-check status: success
Details

@justjais justjais moved this from Module in Review to Module Completed in Ansible 2.9 Networking Feature Dev Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.