Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Remove deprecated 2.9 network settings #59592

Open
wants to merge 1 commit into
base: devel
from

Conversation

@pabelanger
Copy link
Contributor

commented Jul 25, 2019

SUMMARY

Remove deprecated settings from network modules

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible network modules

'port': dict(removed_in_version=2.9, type='int'),
'username': dict(removed_in_version=2.9),
'password': dict(removed_in_version=2.9, no_log=True),
'ssh_keyfile': dict(removed_in_version=2.9, type='path'),
'authorize': dict(type='bool'),

This comment has been minimized.

Copy link
@pabelanger

pabelanger Jul 25, 2019

Author Contributor

So, this wasn't marked to be removed, but I think we want to.

This comment has been minimized.

Copy link
@ganeshrn

ganeshrn Jul 25, 2019

Member

It seems this option was missed out. We can remove it since authorize is also part of provider

'username': dict(removed_in_version=2.9),
'password': dict(removed_in_version=2.9, no_log=True),
'ssh_keyfile': dict(removed_in_version=2.9, type='path'),

'authorize': dict(fallback=(env_fallback, ['ANSIBLE_NET_AUTHORIZE']), type='bool'),

This comment has been minimized.

Copy link
@pabelanger

pabelanger Jul 25, 2019

Author Contributor

same comment

'port': dict(removed_in_version=2.9, type='int'),
'username': dict(removed_in_version=2.9),
'password': dict(removed_in_version=2.9, no_log=True),
'ssh_keyfile': dict(removed_in_version=2.9, type='path'),
'authorize': dict(fallback=(env_fallback, ['ANSIBLE_NET_AUTHORIZE']), type='bool'),

This comment has been minimized.

Copy link
@pabelanger

pabelanger Jul 25, 2019

Author Contributor

same

'username': dict(type='str', removed_in_version=2.9),
'password': dict(type='str', no_log=True, removed_in_version=2.9),
'ssh_keyfile': dict(type='str', removed_in_version=2.9),

'authorize': dict(type='bool', fallback=(env_fallback, ['ANSIBLE_NET_AUTHORIZE'])),

This comment has been minimized.

Copy link
@pabelanger

pabelanger Jul 25, 2019

Author Contributor

same

@pabelanger

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

Pull-request updated, HEAD is now 8d57517

@pabelanger pabelanger force-pushed the pabelanger:temp/remove-network-2.9 branch from 94c7498 to 8d57517 Jul 25, 2019

WIP: Remove deprecated 2.9 network settings
With the 2.9 release coming, we have some code that has been marked
deprecated.

* TODO: This needs to be documented to the user.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
@pabelanger

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2019

Pull-request updated, HEAD is now da4dd36

@pabelanger pabelanger force-pushed the pabelanger:temp/remove-network-2.9 branch from 8d57517 to da4dd36 Jul 25, 2019

@Qalthos
Copy link
Contributor

left a comment

You should also remove the top-level arguments from the platforms' doc fragments in plugins/doc_fragments, where necessary.

@ansible-zuul

This comment has been minimized.

Copy link

commented Jul 25, 2019

@pabelanger

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

recheck

@ansible-zuul

This comment has been minimized.

Copy link

commented Jul 26, 2019

@ansibot ansibot added the stale_ci label Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.