Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option_helpers: improve unit tests for version() #59626

Merged

Conversation

@Andersson007
Copy link
Contributor

commented Jul 26, 2019

SUMMARY

options_helpers: improve unit tests for version()

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

option_helpers
lib/ansible/cli/arguments/option_helpers.py

@Andersson007 Andersson007 force-pushed the Andersson007:improve_unit_tests_for_optparse_helpers branch Jul 26, 2019

@samdoran samdoran requested a review from sivel Jul 26, 2019

@samdoran samdoran self-assigned this Jul 30, 2019

@samdoran samdoran removed the needs_triage label Jul 30, 2019

@samdoran
Copy link
Member

left a comment

Just needs a rebase and this is good to merge.

optparse_helpers: improve unit tests for version()
optparse_helpers: improve unit tests for version()

@Andersson007 Andersson007 force-pushed the Andersson007:improve_unit_tests_for_optparse_helpers branch to aeb70f9 Aug 14, 2019

@Andersson007

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

@samdoran , thank you, done

@jimi-c jimi-c merged commit 7955405 into ansible:devel Aug 14, 2019

1 check passed

Shippable Run 137168 status is SUCCESS.
Details

adharshsrivatsr added a commit to adharshsrivatsr/ansible that referenced this pull request Aug 19, 2019

optparse_helpers: improve unit tests for version() (ansible#59626)
optparse_helpers: improve unit tests for version()

adharshsrivatsr added a commit to adharshsrivatsr/ansible that referenced this pull request Aug 20, 2019

optparse_helpers: improve unit tests for version() (ansible#59626)
optparse_helpers: improve unit tests for version()

nkatarmal-crest added a commit to ciscoecosystem/ansible that referenced this pull request Aug 22, 2019

optparse_helpers: improve unit tests for version() (ansible#59626)
optparse_helpers: improve unit tests for version()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.