-
Notifications
You must be signed in to change notification settings - Fork 24k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pipelining in buildah connection plugin #59745
Conversation
As noted in #57552, this allows pipelining to be used with ansible-bender, greatly improving container build times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Anything I can do to help move this along? I'd like to create a backport PR for 2.8 but I'm waiting until this is accepted. |
rebuild_merge |
1 similar comment
rebuild_merge |
Backport is here: #61390 |
* Fix pipelining in buildah plugin * Add changelog fragment
* Fix pipelining in buildah plugin * Add changelog fragment
SUMMARY
This PR fixes pipelining support in the buildah connection plugin - offered as a much simpler alternative to #57552 / the buildah version of #57579
ISSUE TYPE
COMPONENT NAME
plugins/connection/buildah.py
ADDITIONAL INFORMATION
Unlike the podman plugin, this plugin declares that it supports pipelining, but like the podman plugin, it does not actually pass
in_data
along. cc @TomasTomecek