Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipelining in buildah connection plugin #59745

Merged
merged 2 commits into from
Aug 27, 2019

Conversation

jordemort
Copy link
Contributor

SUMMARY

This PR fixes pipelining support in the buildah connection plugin - offered as a much simpler alternative to #57552 / the buildah version of #57579

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/connection/buildah.py

ADDITIONAL INFORMATION

Unlike the podman plugin, this plugin declares that it supports pipelining, but like the podman plugin, it does not actually pass in_data along. cc @TomasTomecek

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. labels Jul 29, 2019
@jordemort
Copy link
Contributor Author

As noted in #57552, this allows pipelining to be used with ansible-bender, greatly improving container build times.

@ansibot ansibot removed the new_contributor This PR is the first contribution by a new community member. label Jul 30, 2019
Copy link
Contributor

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ansibot ansibot removed the needs_triage Needs a first human triage before being processed. label Jul 31, 2019
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 9, 2019
@jordemort
Copy link
Contributor Author

Anything I can do to help move this along? I'd like to create a backport PR for 2.8 but I'm waiting until this is accepted.

@TomasTomecek
Copy link
Contributor

CC @abadger @sivel

@sivel
Copy link
Member

sivel commented Aug 21, 2019

rebuild_merge

1 similar comment
@sivel
Copy link
Member

sivel commented Aug 27, 2019

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed community_review In order to be merged, this PR must follow the community review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Aug 27, 2019
@ansibot ansibot merged commit 27cac74 into ansible:devel Aug 27, 2019
@jordemort
Copy link
Contributor Author

Backport is here: #61390

adharshsrivatsr pushed a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
* Fix pipelining in buildah plugin

* Add changelog fragment
anas-shami pushed a commit to anas-shami/ansible that referenced this pull request Sep 23, 2019
* Fix pipelining in buildah plugin

* Add changelog fragment
@ansible ansible locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. shipit This PR is ready to be merged by Core support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants