Fix pipelining in buildah connection plugin#59745
Merged
Merged
Conversation
ansibot
added
affects_2.9
Contributor
Author
|
As noted in #57552, this allows pipelining to be used with ansible-bender, greatly improving container build times. |
ansibot
removed
the
new_contributor
ansibot
removed
the
needs_triage
ansibot
added
the
stale_ci
Contributor
Author
|
Anything I can do to help move this along? I'd like to create a backport PR for 2.8 but I'm waiting until this is accepted. |
Contributor
Member
|
rebuild_merge |
1 similar comment
Member
|
rebuild_merge |
ansibot
added
shipit
Contributor
Author
|
Backport is here: #61390 |
adharshsrivatsr
pushed a commit
to adharshsrivatsr/ansible
that referenced
this pull request
Sep 3, 2019
* Fix pipelining in buildah plugin * Add changelog fragment
anas-shami
pushed a commit
to anas-shami/ansible
that referenced
this pull request
Sep 23, 2019
* Fix pipelining in buildah plugin * Add changelog fragment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes pipelining support in the buildah connection plugin - offered as a much simpler alternative to #57552 / the buildah version of #57579
ISSUE TYPE
COMPONENT NAME
plugins/connection/buildah.pyADDITIONAL INFORMATION
Unlike the podman plugin, this plugin declares that it supports pipelining, but like the podman plugin, it does not actually pass
in_dataalong. cc @TomasTomecek