vos_config collection fix using FQCN #60446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
WIP
|
Build succeeded (third-party-check pipeline).
|
Qalthos
suggested changes
Aug 14, 2019
lib/ansible/plugins/action/vyos.py
Outdated
| @@ -38,7 +38,7 @@ class ActionModule(ActionNetworkModule): | |||
| def run(self, tmp=None, task_vars=None): | |||
| del tmp # tmp no longer has any effect | |||
|
|
|||
| self._config_module = True if self._task.action == 'vyos_config' else False | |||
| self._config_module = True if 'vyos_config' in self._task.action else False | |||
There was a problem hiding this comment.
I'd rather see something like
Suggested change
| self._config_module = True if 'vyos_config' in self._task.action else False | |
| module_name = self._task.action.split('.')[-1] | |
| self._config_module = True if module_name == 'vyos_config' else False |
So that we're checking the whole module name. Otherwise if someone has a custom module named, e.g. vyos_configuration, unexpected things might happen.
ansibot
removed
the
needs_triage
This deals with hardcoded vos_config in our vyos action plugin. Needed for when we move to collections. Signed-off-by: Paul Belanger <pabelanger@redhat.com>
|
Pull-request updated, HEAD is now f2660af |
pabelanger
force-pushed
the
temp/vyos.vyos
branch
from
cb0849f
to
f2660af
Compare
pabelanger
changed the title
ansibot
added
core_review
|
Build succeeded (third-party-check pipeline).
|
ansibot
added
needs_revision
Qalthos
approved these changes
Aug 20, 2019
ansibot
added
core_review
adharshsrivatsr
pushed a commit
to adharshsrivatsr/ansible
that referenced
this pull request
Sep 3, 2019
This deals with hardcoded vos_config in our vyos action plugin. Needed for when we move to collections. Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Do not merge, testing collections
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION