Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table headers and width #60549

Open
wants to merge 1 commit into
base: devel
from

Conversation

@abadger
Copy link
Member

commented Aug 13, 2019

  • Don't use the :widths: parameter to rst's table directive. With the
    read-the-docs theme, it seems to have the side-effect of allocating
    the full page width for the table but not filling it all with content.
  • For the platform_index table, use some CSS to add column delimiters on
    the header cells. Otherwise the column spanning headers are hard to
    read. (This is done specifically for this table but if we discover
    other tables with similar problems we can generalize this to the
    common CSS)
ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Fix table headers and width
* Don't use the :widths: parameter to rst's table directive. With the
  read-the-docs theme, it seems to have the side-effect of allocating
  the full page width for the table but not filling it all with content.
* For the platform_index table, use some CSS to add column delimiters on
  the header cells.  Otherwise the column spanning headers are hard to
  read.  (This is done specifically for this table but if we discover
  other tables with similar problems we can generalize this to the
  common CSS)

@abadger abadger force-pushed the abadger:table-headers-width branch from 9585886 to 5926230 Aug 14, 2019

@abadger

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

Screenshot of the new table header:

table-header

The other part of this change, removing :width: auto seems to have fixed the main table on platform_nxos but doesn't have any effect (positive or negative) on other tables. Here's a screenshot of nxos to show where it is fixing things:

Old:

old-platform-nxos-content-does-not-fill-table

New:
new-platform-nxos-content-fills-table

@NilashishC NilashishC requested a review from Qalthos Aug 14, 2019

@Qalthos Qalthos requested a review from samccann Aug 14, 2019

@acozine acozine removed the needs_triage label Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.