Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
VMware: vmware_guest_tools_wait module returns vmware tools facts only #60628
Let this module only return VMware tools related info and guest info, which will be more useful for user to check result. And VM facts can be gathered using vmware_guest_facts module.
Will only return VMware tools related guest info and tools info.
jillr left a comment
I don't disagree with the intent, however this will change the data being returned by this module which could be a breaking change for users if they are depending on these facts. It would probably be better to deprecate this module and create a new one with the new behaviour.
It would also be nice to get tests for the new behaviour that we can run on the worldstream environment (as govcsim does not support VMware tools status reporting we do not have many tests for this module now).
Ok, I see, it makes sense. So maybe a new module for getting vmware tools related info "vmware_guest_tools_info" can be created for this request. Thanks.