Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VMware: vmware_guest_tools_wait module returns vmware tools facts only #60628

Open
wants to merge 1 commit into
base: devel
from

Conversation

@Tomorrow9
Copy link
Contributor

commented Aug 15, 2019

SUMMARY

Let this module only return VMware tools related info and guest info, which will be more useful for user to check result. And VM facts can be gathered using vmware_guest_facts module.
Also add the check of VM power status and VMware tools installed status before waiting for tools running.

Fixes #60258

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

vmware_guest_tools_wait

ADDITIONAL INFORMATION

Will only return VMware tools related guest info and tools info.

ok: [localhost] => {
    "tools_facts": {
        "changed": true, 
        "failed": false, 
        "instance": {
            "vm_guest_fullname": "Microsoft Windows 10 (64-bit)", 
            "vm_guest_hostname": "DESKTOP-CR5CAD6", 
            "vm_guest_id": "windows9_64Guest", 
            "vm_hw_version": "vmx-14", 
            "vm_ipaddress": "10.10.10.10", 
            "vm_name": "dw_test_vm", 
            "vm_tools_install_status": "toolsOk", 
            "vm_tools_install_type": "guestToolsTypeMSI", 
            "vm_tools_last_install_count": 0, 
            "vm_tools_running_status": "guestToolsRunning", 
            "vm_tools_upgrade_policy": "manual", 
            "vm_tools_version": 10341, 
            "vm_tools_version_status": "guestToolsCurrent"
        }
    }
}
@ansibot

This comment has been minimized.

@Tomorrow9

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

Hi @Akasurde @goneri @jillr, would you please review this change? Thanks.

@jillr
Copy link
Contributor

left a comment

I don't disagree with the intent, however this will change the data being returned by this module which could be a breaking change for users if they are depending on these facts. It would probably be better to deprecate this module and create a new one with the new behaviour.

It would also be nice to get tests for the new behaviour that we can run on the worldstream environment (as govcsim does not support VMware tools status reporting we do not have many tests for this module now).

@Tomorrow9

This comment has been minimized.

Copy link
Contributor Author

commented Sep 9, 2019

I don't disagree with the intent, however this will change the data being returned by this module which could be a breaking change for users if they are depending on these facts. It would probably be better to deprecate this module and create a new one with the new behaviour.

It would also be nice to get tests for the new behaviour that we can run on the worldstream environment (as govcsim does not support VMware tools status reporting we do not have many tests for this module now).

Ok, I see, it makes sense. So maybe a new module for getting vmware tools related info "vmware_guest_tools_info" can be created for this request. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.