Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: K8s apply check mode fix #60629

Closed
wants to merge 2 commits into from

Conversation

@willthames
Copy link
Contributor

commented Aug 15, 2019

SUMMARY

Fix check mode for k8s apply

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

k8s

ADDITIONAL INFORMATION
@willthames

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

WIP until openshift/openshift-restclient-python#315 (or an equivalent solution) is merged and released

@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/k8s/raw.py:63:1: E302 expected 2 blank lines, found 1

click here for bot help

@willthames willthames force-pushed the willthames:k8s_apply_check_mode_fix branch to 884b7f6 Aug 17, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/module_utils/k8s/raw.py:63:1: E302 expected 2 blank lines, found 1

click here for bot help

@ansibot ansibot added the ci_verified label Aug 17, 2019

@ansibot ansibot added the stale_ci label Aug 31, 2019

willthames added 2 commits Aug 14, 2019
Ensure k8s apply works with check mode
Update the new predicted object with fields from the previous object
before applying in check mode

Don't log output of `file` with `state: absent` on huge virtualenvs!

Fixes #60510
Use openshift client fix to improve apply for check mode
Use new apply_object method to get a better approximation
of the expected object in check mode.

Requires released upgrade to openshift

@willthames willthames force-pushed the willthames:k8s_apply_check_mode_fix branch from 884b7f6 to ba64562 Sep 2, 2019

@willthames

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

I'll close this one as it really should have gone on to the #60572 PR

@willthames willthames closed this Sep 5, 2019

@sivel sivel removed the needs_triage label Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.