Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AV-63190 Updated ansible modules, fixes for ansible sanity tests #60671

Open
wants to merge 3 commits into
base: devel
from

Conversation

@Rohan-sss1
Copy link

commented Aug 16, 2019

SUMMARY

Updated modules documentation and added new introduced fields

ISSUE TYPE
  • Docs Pull Request
  • Feature Pull Request
COMPONENT NAME

network/avi/avi_actiongroupconfig.py
network/avi/avi_alertconfig.py
network/avi/avi_alertemailconfig.py
network/avi/avi_alertscriptconfig.py
network/avi/avi_alertsyslogconfig.py
network/avi/avi_analyticsprofile.py
network/avi/avi_api_session.py
network/avi/avi_api_version.py
network/avi/avi_applicationpersistenceprofile.py
network/avi/avi_applicationprofile.py
network/avi/avi_authprofile.py
network/avi/avi_autoscalelaunchconfig.py
network/avi/avi_backup.py
network/avi/avi_backupconfiguration.py
network/avi/avi_certificatemanagementprofile.py
network/avi/avi_cloud.py
network/avi/avi_cloudconnectoruser.py
network/avi/avi_cloudproperties.py
network/avi/avi_cluster.py
network/avi/avi_clusterclouddetails.py
network/avi/avi_controllerproperties.py
network/avi/avi_customipamdnsprofile.py
network/avi/avi_dnspolicy.py
network/avi/avi_errorpagebody.py
network/avi/avi_errorpageprofile.py
network/avi/avi_gslb.py
network/avi/avi_gslbgeodbprofile.py
network/avi/avi_gslbservice.py
network/avi/avi_gslbservice_patch_member.py
network/avi/avi_hardwaresecuritymodulegroup.py
network/avi/avi_healthmonitor.py
network/avi/avi_httppolicyset.py
network/avi/avi_ipaddrgroup.py
network/avi/avi_ipamdnsproviderprofile.py
network/avi/avi_l4policyset.py
network/avi/avi_microservicegroup.py
network/avi/avi_network.py
network/avi/avi_networkprofile.py
network/avi/avi_networksecuritypolicy.py
network/avi/avi_pkiprofile.py
network/avi/avi_pool.py
network/avi/avi_poolgroup.py
network/avi/avi_poolgroupdeploymentpolicy.py
network/avi/avi_prioritylabels.py
network/avi/avi_role.py
network/avi/avi_scheduler.py
network/avi/avi_seproperties.py
network/avi/avi_serverautoscalepolicy.py
network/avi/avi_serviceengine.py
network/avi/avi_serviceenginegroup.py
network/avi/avi_snmptrapprofile.py
network/avi/avi_sslkeyandcertificate.py
network/avi/avi_sslprofile.py
network/avi/avi_stringgroup.py
network/avi/avi_systemconfiguration.py
network/avi/avi_tenant.py
network/avi/avi_trafficcloneprofile.py
network/avi/avi_user.py
network/avi/avi_useraccount.py
network/avi/avi_useraccountprofile.py
network/avi/avi_virtualservice.py
network/avi/avi_vrfcontext.py
network/avi/avi_vsdatascriptset.py
network/avi/avi_vsvip.py
network/avi/avi_webhook.py

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

@Rohan-sss1 This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

@Rohan-sss1 Rohan-sss1 force-pushed the avinetworks:AV-63190-UPDATED branch to a33fab1 Aug 16, 2019

@ansibot ansibot added core_review and removed core_review labels Aug 16, 2019

Rohan-sss1 added 2 commits Aug 16, 2019
aws_configuration:
description:
- Awsconfiguration settings for cloud.
type: dict
azure_configuration:
description:
- Field introduced in 17.2.1.

This comment has been minimized.

Copy link
@acozine

acozine Aug 16, 2019

Contributor

Should have a line that actually describes the field - something like Azure configuration settings for cloud. This isn't a blocker for the PR, since the PR doesn't introduce the problem.

extends_documentation_fragment:
- avi
'''

EXAMPLES = """
- name: Create a VMware cloud with write access mode
- name: Create a VMWare cloud with write access mode

This comment has been minimized.

Copy link
@acozine

acozine Aug 16, 2019

Contributor

Lower-case w is correct. See https://www.vmware.com/.

Suggested change
- name: Create a VMWare cloud with write access mode
- name: Create a VMware cloud with write access mode
@@ -210,7 +253,7 @@
enable_vip_static_routes: false
license_type: LIC_CORES
mtu: 1500
name: vCenter Cloud
name: VCenter Cloud

This comment has been minimized.

Copy link
@acozine

acozine Aug 16, 2019

Contributor

Lower-case v is correct here. See https://www.vmware.com/products/vcenter-server.html.

Suggested change
name: VCenter Cloud
name: vCenter Cloud
@acozine
Copy link
Contributor

left a comment

Thanks for specifying the parameter types in the documentation. I'm surprised there are no changes to the sanity-test ignore.txt file . . .

In any case, I found a few places where the docs could be improved. If any of the code edits change the way the module functions, someone should review those changes separately.

@@ -144,7 +166,7 @@ def main():
'Avi python API SDK (avisdk>=17.1) or requests is not installed. '
'For more details visit https://github.com/avinetworks/sdk.'))
return avi_ansible_api(module, 'cloudconnectoruser',
set(['private_key']))
set(['private_key', 'password']))

This comment has been minimized.

Copy link
@acozine

acozine Aug 16, 2019

Contributor

This looks like more than a docs change.

type: int
shared_ssl_certificates:
description:
- Ssl certificates in the admin tenant can be used in non-admin tenants.

This comment has been minimized.

Copy link
@acozine

acozine Aug 16, 2019

Contributor
Suggested change
- Ssl certificates in the admin tenant can be used in non-admin tenants.
- SSL certificates in the admin tenant can be used in non-admin tenants.
url:
description:
- Avi controller URL of the object.
type: str
uuid:
description:
- Uuid of the dns policy.

This comment has been minimized.

Copy link
@acozine

acozine Aug 16, 2019

Contributor
Suggested change
- Uuid of the dns policy.
- UUID of the DNS policy.
@@ -302,7 +329,7 @@ def main():
rsp = api.get('gslb', api_version=api_creds.api_version)
existing_gslb = rsp.json()
gslb = existing_gslb['results']
sites = module.params['gslb_sites_config']
sites = module.params['sites']

This comment has been minimized.

Copy link
@acozine

acozine Aug 16, 2019

Contributor

Here too, this looks like more than just docs.

- A percent value of total se memory reserved for application caching.
- This is an se bootup property and requires se restart.
- A percent value of total se memory reserved for applicationcaching.
- This is an se bootup property and requires se restart.requires se reboot.

This comment has been minimized.

Copy link
@acozine

acozine Aug 16, 2019

Contributor

I'm confused here. Does it require se restart, or se reboot, or both? Or are they the same thing?

se_tunnel_udp_port:
description:
- Udp port for tunneled packets from secondary to primary se in docker bridge mode.
- Udp port for tunneled packets from secondary to primary se in docker bridge mode.requires se reboot.

This comment has been minimized.

Copy link
@acozine

acozine Aug 16, 2019

Contributor
Suggested change
- Udp port for tunneled packets from secondary to primary se in docker bridge mode.requires se reboot.
- UDP port for tunneled packets from secondary to primary se in docker bridge mode. Requires se reboot.
- Field introduced in 18.2.5.
- Default value when not specified in API or module is interpreted by Avi Controller as 64.
version_added: "2.9"
type: int
se_udp_encap_ipc:
description:
- Determines if se-se ipc messages are encapsulated in a udp header 0 automatically determine based on hypervisor type.

This comment has been minimized.

Copy link
@acozine

acozine Aug 16, 2019

Contributor
Suggested change
- Determines if se-se ipc messages are encapsulated in a udp header 0 automatically determine based on hypervisor type.
- Determines if se-se ipc messages are encapsulated in a UDP header
- set to 0, automatically determine based on hypervisor type
se_udp_encap_ipc:
description:
- Determines if se-se ipc messages are encapsulated in a udp header 0 automatically determine based on hypervisor type.
- 1 use udp encap unconditionally.
- 1 use udp encap unconditionally.requires se reboot.

This comment has been minimized.

Copy link
@acozine

acozine Aug 16, 2019

Contributor
Suggested change
- 1 use udp encap unconditionally.requires se reboot.
- set to 1, use udp encap unconditionally. Requires se reboot.
waf_mempool:
description:
- Enable memory pool for waf.
- Enable memory pool for waf.requires se reboot.

This comment has been minimized.

Copy link
@acozine

acozine Aug 16, 2019

Contributor
Suggested change
- Enable memory pool for waf.requires se reboot.
- Enable memory pool for waf. Requires se reboot.
- Field introduced in 17.2.3.
- Default value when not specified in API or module is interpreted by Avi Controller as True.
version_added: "2.5"
type: bool
waf_mempool_size:
description:
- Memory pool size used for waf.
- Memory pool size used for waf.requires se reboot.

This comment has been minimized.

Copy link
@acozine

acozine Aug 16, 2019

Contributor
Suggested change
- Memory pool size used for waf.requires se reboot.
- Memory pool size used for waf. Requires se reboot.

@acozine acozine removed the needs_triage label Aug 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.