Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.8] fix: docker_swarm_service does not publish both tcp and udp ports #60697

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@felixfontein
Copy link
Contributor

commented Aug 16, 2019

SUMMARY

Backport of #60616 to stable-2.8.

Fixes #60568.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docker_swarm_service

fix: docker_swarm_service does not publish both tcp and udp ports (#6…
…0616)

* fix: docker_swarm_service does not publish both tcp and udp ports for same published port

* fix the linting problems and add the changelog fragment.

* add test

* modify test to ensure result rather than return value

(cherry picked from commit 064cd63)
@hannseman
Copy link
Contributor

left a comment

shipit

@jwitko
jwitko approved these changes Aug 19, 2019

@abadger abadger merged commit db9cb06 into ansible:stable-2.8 Sep 3, 2019

1 check passed

Shippable Run 141103 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Merged for the 2.8.5 release

@felixfontein felixfontein deleted the felixfontein:backport/2.8/60616 branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.