Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] acme_certificate: add select_chain option #60710

Open
wants to merge 11 commits into
base: devel
from

Conversation

@felixfontein
Copy link
Contributor

commented Aug 16, 2019

SUMMARY

This option allows to choose an alternate chain (when provided) depending on some criteria on the certificates in the chain. Can be for example used to select a chain with a more compatible root certificate (i.e. corresponding to the cross-signed intermediates in case of Let's Encrypt), if the CA provides such chains.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

acme_certificate

@ansibot

This comment has been minimized.

@felixfontein felixfontein force-pushed the felixfontein:acme_certificate-alternate-selection branch to 790a1e1 Aug 18, 2019

@felixfontein felixfontein referenced this pull request Aug 18, 2019

@ansibot ansibot added the has_issue label Aug 22, 2019

@felixfontein felixfontein force-pushed the felixfontein:acme_certificate-alternate-selection branch 4 times, most recently from 55c8a00 to 64196c9 Aug 22, 2019

@ansibot

This comment was marked as outdated.

Copy link
Contributor

commented Aug 30, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/crypto/acme/acme_certificate.py:0:0: option-incorrect-version-added: version_added for new option (select_alternate_chain) should be '2.10'. Currently StrictVersion ('2.9')

click here for bot help

@felixfontein felixfontein changed the title [WIP] acme_certificate: add select_alternate_chain option [WIP] acme_certificate: add select_chain option Sep 2, 2019

@ansibot ansibot added the stale_ci label Sep 10, 2019

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2019

Will rebase once #62381 is merged.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

@ansibot ansibot removed the stale_ci label Sep 17, 2019

@felixfontein felixfontein force-pushed the felixfontein:acme_certificate-alternate-selection branch from 4d735a5 to 6eb7140 Sep 17, 2019

@felixfontein

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2019

Still rebased now since all tests fail when there's a conflict.

@ansibot ansibot removed the needs_rebase label Sep 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.