Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetration_user_annotations initial commit #60712

Open
wants to merge 4 commits into
base: devel
from

Conversation

@techBeck03
Copy link

commented Aug 16, 2019

SUMMARY

Adding Cisco Tetration module for managing user annotations

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

tetration_user_annotations

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

@techBeck03, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

The test ansible-test sanity --test pylint [explain] failed with 7 errors:

lib/ansible/module_utils/network/tetration.py:64:38: bad-whitespace Exactly one space required after comma     'server_endpoint': dict(type='str',required=True, aliases=['endpoint','host']),                                       ^
lib/ansible/module_utils/network/tetration.py:64:73: bad-whitespace Exactly one space required after comma     'server_endpoint': dict(type='str',required=True, aliases=['endpoint','host']),                                                                          ^
lib/ansible/module_utils/network/tetration.py:65:30: bad-whitespace Exactly one space required after comma     'api_key': dict(type='str',required=True),                               ^
lib/ansible/module_utils/network/tetration.py:66:33: bad-whitespace Exactly one space required after comma     'api_secret': dict(type='str',required=True,no_log=True),                                  ^
lib/ansible/module_utils/network/tetration.py:66:47: bad-whitespace Exactly one space required after comma     'api_secret': dict(type='str',required=True,no_log=True),                                                ^
lib/ansible/module_utils/network/tetration.py:111:61: bad-whitespace Exactly one space required after comma             super(TetrationApiModule, self).__init__(provider,module)                                                              ^
lib/ansible/module_utils/network/tetration.py:207:27: undefined-variable Undefined variable 'cmp'

The test ansible-test sanity --test botmeta [explain] failed with 2 errors:

.github/BOTMETA.yml:0:0: Can't find 'lib/ansible/module_utils/tetration.py.*' in this branch
.github/BOTMETA.yml:0:0: Can't find 'lib/ansible/modules/networking/tetration/.*' in this branch

The test ansible-test sanity --test future-import-boilerplate [explain] failed with 2 errors:

lib/ansible/module_utils/network/tetration.py:0:0: missing: from __future__ import (absolute_import, division, print_function)
lib/ansible/plugins/doc_fragments/tetration.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test import --python 2.6 [explain] failed with 2 errors:

lib/ansible/module_utils/network/tetration.py:35:0: ImportError: No module named requests.packages.urllib3
test/runner/.tox/import/lib/ansible/module_utils/network/tetration.py:35:0: ImportError: No module named requests.packages.urllib3

The test ansible-test sanity --test import --python 2.7 [explain] failed with 3 errors:

lib/ansible/module_utils/network/tetration.py:35:0: ImportError: No module named requests.packages.urllib3
lib/ansible/modules/network/tetration/tetration_user_annotations.py:142:0: ImportError: No module named requests.packages.urllib3
test/runner/.tox/import/lib/ansible/module_utils/network/tetration.py:35:0: ImportError: No module named requests.packages.urllib3

The test ansible-test sanity --test import --python 3.5 [explain] failed with 3 errors:

lib/ansible/module_utils/network/tetration.py:35:0: ImportError: No module named 'requests'
lib/ansible/modules/network/tetration/tetration_user_annotations.py:142:0: ImportError: No module named 'requests'
test/runner/.tox/import/lib/ansible/module_utils/network/tetration.py:35:0: ImportError: No module named 'requests'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 3 errors:

lib/ansible/module_utils/network/tetration.py:35:0: ModuleNotFoundError: No module named 'requests'
lib/ansible/modules/network/tetration/tetration_user_annotations.py:142:0: ModuleNotFoundError: No module named 'requests'
test/runner/.tox/import/lib/ansible/module_utils/network/tetration.py:35:0: ModuleNotFoundError: No module named 'requests'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 3 errors:

lib/ansible/module_utils/network/tetration.py:35:0: ModuleNotFoundError: No module named 'requests'
lib/ansible/modules/network/tetration/tetration_user_annotations.py:142:0: ModuleNotFoundError: No module named 'requests'
test/runner/.tox/import/lib/ansible/module_utils/network/tetration.py:35:0: ModuleNotFoundError: No module named 'requests'

The test ansible-test sanity --test import --python 3.8 [explain] failed with 3 errors:

lib/ansible/module_utils/network/tetration.py:35:0: ModuleNotFoundError: No module named 'requests'
lib/ansible/modules/network/tetration/tetration_user_annotations.py:142:0: ModuleNotFoundError: No module named 'requests'
test/runner/.tox/import/lib/ansible/module_utils/network/tetration.py:35:0: ModuleNotFoundError: No module named 'requests'

The test ansible-test sanity --test metaclass-boilerplate [explain] failed with 2 errors:

lib/ansible/module_utils/network/tetration.py:0:0: missing: __metaclass__ = type
lib/ansible/plugins/doc_fragments/tetration.py:0:0: missing: __metaclass__ = type

The test ansible-test sanity --test no-dict-iteritems [explain] failed with 1 error:

lib/ansible/module_utils/network/tetration.py:139:36: use `dict.items` or `ansible.module_utils.six.iteritems` instead of `dict.iteritems`

The test ansible-test sanity --test pep8 [explain] failed with 12 errors:

lib/ansible/module_utils/network/tetration.py:64:39: E231 missing whitespace after ','
lib/ansible/module_utils/network/tetration.py:64:74: E231 missing whitespace after ','
lib/ansible/module_utils/network/tetration.py:65:31: E231 missing whitespace after ','
lib/ansible/module_utils/network/tetration.py:66:34: E231 missing whitespace after ','
lib/ansible/module_utils/network/tetration.py:66:48: E231 missing whitespace after ','
lib/ansible/module_utils/network/tetration.py:74:1: E302 expected 2 blank lines, found 1
lib/ansible/module_utils/network/tetration.py:111:62: E231 missing whitespace after ','
lib/ansible/module_utils/network/tetration.py:173:28: E226 missing whitespace around arithmetic operator
lib/ansible/module_utils/network/tetration.py:183:28: E226 missing whitespace around arithmetic operator
lib/ansible/module_utils/network/tetration.py:193:28: E226 missing whitespace around arithmetic operator
lib/ansible/module_utils/network/tetration.py:231:1: E305 expected 2 blank lines after class or function definition, found 1
lib/ansible/plugins/doc_fragments/tetration.py:96:4: W292 no newline at end of file

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

@techBeck03 this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot ansibot added the merge_commit label Sep 5, 2019

@techBeck03 techBeck03 force-pushed the techBeck03:tetration_user_annotations branch from b59e68b to 12c689b Sep 5, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/network/tetration/tetration_user_annotations.py:0:0: module-incorrect-version-added: version_added should be '2.10'. Currently '2.9'

The test ansible-test sanity --test metaclass-boilerplate [explain] failed with 2 errors:

lib/ansible/module_utils/network/tetration.py:0:0: missing: __metaclass__ = type
lib/ansible/plugins/doc_fragments/tetration.py:0:0: missing: __metaclass__ = type

The test ansible-test sanity --test pep8 [explain] failed with 7 errors:

lib/ansible/module_utils/network/tetration.py:180:28: E226: missing whitespace around arithmetic operator
lib/ansible/module_utils/network/tetration.py:190:28: E226: missing whitespace around arithmetic operator
lib/ansible/module_utils/network/tetration.py:200:28: E226: missing whitespace around arithmetic operator
lib/ansible/module_utils/network/tetration.py:214:49: E226: missing whitespace around arithmetic operator
lib/ansible/module_utils/network/tetration.py:238:1: E305: expected 2 blank lines after class or function definition, found 1
lib/ansible/plugins/doc_fragments/tetration.py:20:1: E302: expected 2 blank lines, found 0
lib/ansible/plugins/doc_fragments/tetration.py:96:4: W292: no newline at end of file

click here for bot help

@ansibot ansibot added the ci_verified label Sep 5, 2019

@ansibot ansibot removed the ci_verified label Sep 5, 2019

@ansibot ansibot added core_review and removed needs_revision labels Sep 5, 2019

@ganeshrn ganeshrn self-assigned this Sep 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.