Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add PolicyArns parameters to sts_assume_role #60735

Open
wants to merge 2 commits into
base: devel
from

Conversation

@mathieucoavoux
Copy link

commented Aug 17, 2019

SUMMARY

sts_assume_role is calling the assume_role function of the sts class in boto3
This function supports a new parameter PolicyArns. We have updated the module accordingly
This PR implements #60734 request
Requires botocore 1.12.146 or higher

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2019

@mathieucoavoux, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2019

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/sts_assume_role.py:178:40: bad-whitespace Exactly one space required after comma             policy_arns=dict(type='list',required=False, default=None),                                         ^

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/sts_assume_role.py:178:41: E231 missing whitespace after ','

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/sts_assume_role.py:0:0: E309 version_added for new option (policy_arns) should be '2.9'. Currently StrictVersion ('0.0')

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

lib/ansible/modules/cloud/amazon/sts_assume_role.py:111:1: key-duplicates EXAMPLES: duplication of key "sts_assume_role" in mapping
lib/ansible/modules/cloud/amazon/sts_assume_role.py:116:1: key-duplicates EXAMPLES: duplication of key "register" in mapping

click here for bot help

@mathieucoavoux

This comment has been minimized.

Copy link
Author

commented Aug 17, 2019

The integration test failed dues to a restricted permission when it tries to create a policy.
We added a new test to create a policy to be able to test the requested change

@mathieucoavoux

This comment has been minimized.

Copy link
Author

commented Aug 17, 2019

Can this integration test run with the same permissions as iam_policy as it able to create a user ? Or can I use the policy available within this integration test ?

@ansibot ansibot added the stale_ci label Aug 31, 2019

@mathieucoavoux

This comment has been minimized.

Copy link
Author

commented Sep 12, 2019

Hi @s-hertel and @kyleknap
I would like to remove the WIP in order that the MR is taken into account but I am facing an issue with the integration test.
As you worked on integration test for the iam_policy, you may have an idea how I can do it for this case.

Many thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.