Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Add exception handling to win_domain_controller (#58234) #60753

Merged
merged 1 commit into from Sep 4, 2019

Conversation

@agowa338
Copy link
Contributor

commented Aug 19, 2019

SUMMARY

Add error handling for two exceptions.

Backport: #58234

  • Add exception handling to win_domain_controller
  • Add changelog
  • Fix PSUseDeclaredVarsMoreThanAssignments
  • Remove dns domain cannot be resolved error message
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_domain_controller

ADDITIONAL INFORMATION

If a user specifies a domain to join that cannot be resolved by dns, the Install-ADDSDomainController command throws an Microsoft.ADRoles.Deployment.Common.Tests.TestFailedException exception.

If the module is either invoked twice without a reboot, or a reboot is pending for another reason the Install-ADDSDomainController command throws an Microsoft.DirectoryServices.Deployment.DCPromoExecutionException exception with Errorcode 15.

I added error handling for both of them, so that a user can handle them from within the playbook.

@ansibot

This comment has been minimized.

@abadger

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Could you resolve the conflicts so this can be merged? Usually, changelogs for separate PRs are placed into separate changelog fragment files.

Add exception handling to win_domain_controller (#58234)
* Add exception handling to win_domain_controller

* Add changelog

* Fix PSUseDeclaredVarsMoreThanAssignments

* Remove dns domain cannot be resolved error message

As requested by PR review in #58234 (comment)
@agowa338

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

!needs_revision

@abadger abadger merged commit 0af0a7f into ansible:stable-2.8 Sep 4, 2019

1 check passed

Shippable Run 141744 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Sep 4, 2019

Merged for the 2.8.5 release

@agowa338 agowa338 deleted the agowa338:stable-2.8#58234 branch Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.