Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: win_domain reboot required exception incorrectly reported (#60496) #60809

Merged
merged 2 commits into from Sep 3, 2019

Conversation

@agowa338
Copy link
Contributor

commented Aug 19, 2019

SUMMARY

If the module fails because a reboot is pending it is stated in the exception message, but reboot_required is still false.

Fixes: #60493
Backports: #60496

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

win_domain

ADDITIONAL INFORMATION
fatal: [****-****]: FAILED! => {
    "changed": true,
    "msg": "Failed to install ADDSForest with DCPromo: Name change pending. A reboot is required.\r\n",
    "reboot_required": false
}
agowa338 added 2 commits Aug 18, 2019
win_domain reboot required exception incorrectly reported (#60496)
* Set reboot required dependent on exception message.

* Use exception id instead of it's message
@ansibot

This comment has been minimized.

@ansibot ansibot added the stale_ci label Aug 30, 2019

@abadger abadger merged commit ec50e11 into ansible:stable-2.8 Sep 3, 2019

1 check passed

Shippable Run 138085 status is SUCCESS.
Details
@abadger

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Merged for the 2.8.5 release.

@agowa338 agowa338 deleted the agowa338:stable-2.8#60496 branch Sep 4, 2019

@sivel sivel removed the needs_triage label Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.