Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sns_topic ensure "changed" works as expected when managing delivery policies #60944

Open
wants to merge 3 commits into
base: devel
from

Conversation

@tremble
Copy link
Contributor

commented Aug 20, 2019

SUMMARY

when delivery_policy was set it always returned "changed" because delivery_policy isn't an IAM policy so wasn't handled properly.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/sns_topic.py

ADDITIONAL INFORMATION

Integration tests updated

@tremble tremble force-pushed the tremble:sns_changed branch 2 times, most recently Aug 20, 2019

@tremble

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2019

@willthames git blames you for a large chunk of the code, would you be so kind as to take a look please.

@ansibot

This comment was marked as resolved.

Copy link
Contributor

commented Aug 20, 2019

The test ansible-test sanity --test changelog [explain] failed with 1 error:

changelogs/fragments/60944-sns_topic-delivery_policy-changed:0:0: extension must be one of: .yml, .yaml

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/sns_topic.py:296:5: E303 too many blank lines (2)

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

sns_topic: ensure "changed" behaves properly when managing delivery p…
…olicies

- a delivery_policy isn't an IAM policy, so compare_policies didn't cope with it
- AWS automatically adds an additional option when you set an HTTP delivery
  policy

@tremble tremble force-pushed the tremble:sns_changed branch to 59b2795 Aug 20, 2019

@ansibot ansibot added the stale_ci label Aug 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.