Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check module names in action plugin without collection attached #60947

Merged
merged 5 commits into from Aug 31, 2019

Conversation

@Qalthos
Copy link
Contributor

commented Aug 20, 2019

SUMMARY

Like #60446, but for the other supported platforms

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

eos_config

Depends-On: #61605
Depends-On: #61592

@Qalthos Qalthos requested review from pabelanger and ganeshrn Aug 20, 2019

@ansibot

This comment has been minimized.

@ansible-zuul

This comment has been minimized.

Copy link

commented Aug 20, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

pabelanger added a commit to pabelanger/ansible_collections.arista.eos that referenced this pull request Aug 22, 2019
Add network integration files
This is needed to have ansible-test work properly.

Depends-On: ansible/ansible#60947
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible_collections.cisco.ios that referenced this pull request Aug 22, 2019
Add ansible-test bits for integration tests
Depends-On: ansible/ansible#60947
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
pabelanger added a commit to pabelanger/ansible_collections.arista.eos that referenced this pull request Aug 22, 2019
Add network integration files
This is needed to have ansible-test work properly.

Depends-On: ansible/ansible#60947
Depends-On: ansible/ansible#60420
Signed-off-by: Paul Belanger <pabelanger@redhat.com>

@Qalthos Qalthos changed the title Check for eos_config in action plugin by module name only, not full name with collection Check module names in action plugin without collection attached Aug 27, 2019

@Qalthos Qalthos force-pushed the Qalthos:eos_config_fqdn branch from ff71839 to 9ce3c69 Aug 27, 2019

@ikhan2010 ikhan2010 added the P2 label Aug 27, 2019

@Qalthos
Copy link
Contributor Author

left a comment

Whoops

lib/ansible/plugins/action/junos.py Outdated Show resolved Hide resolved
@ansible-zuul

This comment has been minimized.

@ansible-zuul

This comment has been minimized.

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

recheck

@abadger

This comment has been minimized.

Copy link
Member

commented Aug 29, 2019

This looks to be a non-invasive bugfix and can be merged between beta1 and rc1. not blocking beta1 on it.

@ansible-zuul

This comment has been minimized.

Copy link

commented Aug 30, 2019

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

recheck

@ansible-zuul

This comment has been minimized.

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

recheck

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

This fixes our collection issue, but we need to fix tests here.

@ansible-zuul

This comment has been minimized.

Copy link

commented Aug 30, 2019

This change depends on a change that failed to merge.

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

closing to re-trigger jobs

@ansible-zuul

This comment has been minimized.

Copy link

commented Aug 30, 2019

This change depends on a change that failed to merge.

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

recheck

@ansible-zuul

This comment has been minimized.

Copy link

commented Aug 30, 2019

This change depends on a change that failed to merge.

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

recheck

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

recheck

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

recheck

@pabelanger

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

The iosxr error above, is new to me, but believe we have an open issue for it.

@pabelanger pabelanger merged commit e89048f into ansible:devel Aug 31, 2019

2 checks passed

Shippable Run 141203 status is SUCCESS.
Details
ansible/third-party-check third-party-check status: success
Details
adharshsrivatsr added a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
Check module names in action plugin without collection attached (ansi…
…ble#60947)

* Check for eos_config in action plugin by module name, not entire fqmn

* Modify toher action plugins to find module name

* Restore missing `not`

* Cover netconf plugin as well

* Whoops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.