Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ec2_vpc_vgw broken tests #60981

Merged
merged 4 commits into from Sep 9, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Prev

better waiter naming

  • Loading branch information...
jillr committed Sep 9, 2019
commit 34936b5f975dab904129773adfafd95b9a98513f
@@ -330,8 +330,8 @@ def rds_model(name):
core_waiter.NormalizedOperationMethod(
ec2.describe_vpn_gateways
)),
('EC2', 'vgw_detached'): lambda ec2: core_waiter.Waiter(
'vgw_detached',
('EC2', 'vpn_gateway_detached'): lambda ec2: core_waiter.Waiter(
'vpn_gateway_detached',
ec2_model('VpnGatewayDetached'),
core_waiter.NormalizedOperationMethod(
ec2.describe_vpn_gateways
@@ -406,7 +406,7 @@ def ensure_vgw_present(client, module):
# detach the existing vpc from the virtual gateway
vpc_to_detach = current_vpc_attachments[0]['VpcId']
detach_vgw(client, module, vpn_gateway_id, vpc_to_detach)
get_waiter(client, 'vgw_detached').wait(VpnGatewayIds=[vpn_gateway_id])
get_waiter(client, 'vpn_gateway_detached').wait(VpnGatewayIds=[vpn_gateway_id])
attached_vgw = attach_vgw(client, module, vpn_gateway_id)
changed = True
else:
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.