Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added uptime to default subset - ios_facts #61019

Open
wants to merge 1 commit into
base: devel
from

Conversation

@Yannis100
Copy link
Contributor

commented Aug 21, 2019

SUMMARY

Add uptime for ios_facts

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ios_facts, ansible_facts

ADDITIONAL INFORMATION

It might be interesting to split "interfaces" and "topology" (cdp, lldp) subsets ?
Add restart time, reload reason as in the task 'get_facts' provided in the role 'ansible-network.cisco_ios' ?
Backport changes (cdp neighbors, ios_type, api, python_version) to 2.7 branch ?

Please check before merging, not 100% sure of my code
Feel free to add a unit test for this, otherwise I'll do it when I have time

Copy of #59852 but rebased following the merge of #59716
Referring #57334 #50463

ok: [10.1.62.10] => {
    "ansible_facts": {
        "ansible_net_filesystems": [
            "flash:"
        ],
        "ansible_net_filesystems_info": {
            "flash:": {
                "spacefree_kb": 942784,
                "spacetotal_kb": 1586040
            }
        },
        "ansible_net_gather_subset": [
            "hardware",
            "default"
        ],
        "ansible_net_hostname": "hostname",
        "ansible_net_image": "flash:packages.conf",
        "ansible_net_memfree_mb": 509320,
        "ansible_net_memtotal_mb": 832828,
        "ansible_net_model": "WS-C3850-48P",
        "ansible_net_serialnum": "FCW0000X0XX",
        "ansible_net_stacked_models": [
            "WS-C3850-48P"
        ],
        "ansible_net_stacked_serialnums": [
            "FCW2030D0KC"
        ],
        **"ansible_net_uptime": "1 week, 5 days, 20 hours, 42 minutes",**
        "ansible_net_version": "16.09.03a"
    }

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

@Yannis100, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@Yannis100

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

recheck

@ansible-zuul

This comment has been minimized.

Copy link

commented Aug 29, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@justjais

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

recheck

@ansibot ansibot removed the needs_triage label Aug 29, 2019

@ansible-zuul

This comment has been minimized.

Copy link

commented Aug 29, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@justjais

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

@Yannis100 can u fix the shippable errors, coz the ansible error is not related to the PR (ref: #61305)

@Yannis100

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

I would love to but can't find a relevant error message in shippable logs
The only issue I see is with 'git_sync' 'git fetch origin pull/61019/head'
I wanted to relaunch the Shippable run but I don't know how to do it (shipit ?)

@Yannis100

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

A different issue in shippable now, not sure if the failure is related to my code

I identified the following tests that needs to be updated
test/units/modules/network/ios/test_ios_facts.py
test/integration/targets/ios_facts/tests/cli/default_facts.yaml
test/integration/targets/ios_facts/tests/cli/all_facts.yaml

@ansibot ansibot added the stale_ci label Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.