Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubevirt: also add wait_sleep #61020

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@mmazur
Copy link
Contributor

commented Aug 21, 2019

SUMMARY

wait_sleep got added to k8s modules; this needs to be reflected in kubevirt modules for them to not break

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

kubevirt

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

@mmazur mmazur force-pushed the mmazur:kubevirt_add_wait_sleep branch 2 times, most recently Aug 22, 2019

@mmazur mmazur referenced this pull request Aug 22, 2019

@mmazur mmazur force-pushed the mmazur:kubevirt_add_wait_sleep branch to ce3504a Aug 22, 2019

@mmazur

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

@pkliczewski

This comment has been minimized.

Copy link

commented Aug 23, 2019

+1

@mmazur

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

bot_status

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

Components

lib/ansible/module_utils/kubevirt.py
support: community
maintainers: machacekondra mmazur pkliczewski

lib/ansible/plugins/doc_fragments/kubevirt_common_options.py
support: community
maintainers:

Metadata

waiting_on: maintainer
changes_requested_by: null
needs_info: False
needs_revision: False
needs_rebase: False
merge_commits: []
too many files or commits: False
mergeable_state: clean
shippable_status: success
maintainer_shipits (module maintainers): 2
community_shipits (namespace maintainers): 0
ansible_shipits (core team members): 0
shipit_actors (maintainers or core team members): mmazur pkliczewski
shipit_actors_other: []
automerge: automerge is_module test failed

click here for bot help

@mmazur

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2019

Ah, right, this touches files we don't control. Oh well, need to wait for someone with privileges to merge this.

@mmazur

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

@willthames hi, k8s code got a patch in some time ago that broke our stuff, but fixing it requires someone with higher access to actually merge this PR. Could you help?

@Akasurde Akasurde merged commit cf86a5e into ansible:devel Sep 2, 2019

1 check passed

Shippable Run 139194 status is SUCCESS.
Details
adharshsrivatsr added a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.