Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: cvs snapshots for aws #61023

Merged
merged 2 commits into from Aug 29, 2019

Conversation

@carchi8py
Copy link
Contributor

commented Aug 21, 2019

SUMMARY

New module: cvs snapshots for aws

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • aws_netapp_cvs_snapshots.py
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

@carchi8py, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 21, 2019

The test ansible-test sanity --test ansible-doc [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_netapp_cvs_snapshots.py:0:0: missing documentation (or could not parse documentation): unknown doc_fragment(s) in file /root/ansible/lib/ansible/modules/cloud/amazon/aws_netapp_cvs_snapshots.py: netapp.awscvs

The test ansible-test sanity --test docs-build [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/docs-build.py" returned exit status 1.
>>> Standard Error
Command 'make singlehtmldocs' failed with status code: 2
--> Standard Output
PYTHONPATH=../../lib ../../hacking/build-ansible.py collection-meta --template-file=../templates/collections_galaxy_meta.rst.j2 --output-dir=rst/dev_guide/ ../../lib/ansible/galaxy/data/collections_galaxy_meta.yml
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-config --template-file=../templates/config.rst.j2 --output-dir=rst/reference_appendices/ ../../lib/ansible/config/base.yml
mkdir -p rst/cli
PYTHONPATH=../../lib ../../hacking/build-ansible.py generate-man --template-file=../templates/cli_rst.j2 --output-dir=rst/cli/ --output-format rst ../../lib/ansible/cli/*.py
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-keywords --template-dir=../templates --output-dir=rst/reference_appendices/ ./keyword_desc.yml
PYTHONPATH=../../lib ../../hacking/build-ansible.py document-plugins -t rst --template-dir=../templates --module-dir=../../lib/ansible/modules -o rst/modules/ 
Evaluating module files...
Makefile:99: recipe for target 'modules' failed
--> Standard Error
Traceback (most recent call last):
  File "../../hacking/build-ansible.py", line 88, in <module>
    main()
  File "../../hacking/build-ansible.py", line 79, in main
    retval = command.main(args)
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 711, in main
    plugin_info, categories = get_plugin_info(args.module_dir, limit_to=args.limit_to, verbose=(args.verbosity > 0))
  File "/root/ansible/hacking/build_library/build_ansible/command_plugins/plugin_formatter.py", line 225, in get_plugin_info
    doc, examples, returndocs, metadata = plugin_docs.get_docstring(module_path, fragment_loader, verbose=verbose)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 128, in get_docstring
    add_fragments(data['doc'], filename, fragment_loader=fragment_loader)
  File "/root/ansible/lib/ansible/utils/plugin_docs.py", line 116, in add_fragments
    raise AnsibleError('unknown doc_fragment(s) in file {0}: {1}'.format(filename, to_native(', '.join(unknown_fragments))))
ansible.errors.AnsibleError: unknown doc_fragment(s) in file ../../lib/ansible/modules/cloud/amazon/aws_netapp_cvs_snapshots.py: netapp.awscvs
make: *** [modules] Error 1

The test ansible-test sanity --test package-data [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/package-data.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 373, in <module>
    main()
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 350, in main
    sdist_path = create_sdist(tmp_dir)
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 175, in create_sdist
    raise Exception('sdist was not created in the temp dir')
Exception: sdist was not created in the temp dir

The test ansible-test sanity --test future-import-boilerplate [explain] failed with 1 error:

test/units/modules/cloud/amazon/test_aws_netapp_cvs_snapshots.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test import --python 2.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_netapp_cvs_snapshots.py:97:0: ImportError: cannot import name AwsCvsRestAPI

The test ansible-test sanity --test import --python 2.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_netapp_cvs_snapshots.py:97:0: ImportError: cannot import name AwsCvsRestAPI

The test ansible-test sanity --test import --python 3.5 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_netapp_cvs_snapshots.py:97:0: ImportError: cannot import name 'AwsCvsRestAPI'

The test ansible-test sanity --test import --python 3.6 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_netapp_cvs_snapshots.py:97:0: ImportError: cannot import name 'AwsCvsRestAPI'

The test ansible-test sanity --test import --python 3.7 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_netapp_cvs_snapshots.py:97:0: ImportError: cannot import name 'AwsCvsRestAPI' from 'ansible.module_utils.netapp' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/netapp.py)

The test ansible-test sanity --test import --python 3.8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_netapp_cvs_snapshots.py:97:0: ImportError: cannot import name 'AwsCvsRestAPI' from 'ansible.module_utils.netapp' (/root/ansible/test/runner/.tox/import/lib/ansible/module_utils/netapp.py)

The test ansible-test sanity --test metaclass-boilerplate [explain] failed with 1 error:

test/units/modules/cloud/amazon/test_aws_netapp_cvs_snapshots.py:0:0: missing: __metaclass__ = type

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Aug 21, 2019

@jillr jillr removed the needs_triage label Aug 22, 2019

@carchi8py carchi8py force-pushed the carchi8py:1850 branch from ce6bd3d to 727269f Aug 26, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

The test ansible-test sanity --test future-import-boilerplate [explain] failed with 1 error:

test/units/modules/cloud/amazon/test_aws_netapp_cvs_snapshots.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test metaclass-boilerplate [explain] failed with 1 error:

test/units/modules/cloud/amazon/test_aws_netapp_cvs_snapshots.py:0:0: missing: __metaclass__ = type

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/cloud/amazon/aws_netapp_cvs_snapshots.py:0:0: E312 No RETURN provided
lib/ansible/modules/cloud/amazon/aws_netapp_cvs_snapshots.py:0:0: E337 Argument 'api_key' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/amazon/aws_netapp_cvs_snapshots.py:0:0: E337 Argument 'api_url' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/amazon/aws_netapp_cvs_snapshots.py:0:0: E337 Argument 'secret_key' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/cloud/amazon/aws_netapp_cvs_snapshots.py:0:0: E338 Argument 'state' in argument_spec uses default type ('str') but documentation doesn't define type

click here for bot help

@ansibot ansibot added the ci_verified label Aug 26, 2019


if self.snapshotId is None and 'fileSystemId' in self.data:
self.fileSystemId = self.getfilesystemId()
self.data['fileSystemId'] = self.fileSystemId

This comment has been minimized.

Copy link
@lonico

lonico Aug 26, 2019

Contributor

should be moved after line 205 (otherwise the error message is reporting None).

self.restApi = AwsCvsRestAPI(self.module)

# Checking for the parameters passed and create new parameters list
self.data = {}

This comment has been minimized.

Copy link
@lonico

lonico Aug 26, 2019

Contributor

why do we need a deep copy of self.parameters? It seems self.data is redundant.

@thedoubl3j
Copy link
Contributor

left a comment

Everything looks good. tests are present and docs look good. shipit

@ansibot ansibot added shipit and removed core_review labels Aug 29, 2019

@thedoubl3j thedoubl3j merged commit 799b0fa into ansible:devel Aug 29, 2019

1 check passed

Shippable Run 139888 status is SUCCESS.
Details
adharshsrivatsr added a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
New module: cvs snapshots for aws (ansible#61023)
* New module: cvs snapshots for aws

* fixeS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.