Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win_robocopy add md5 checksum check for copy #61118

Open
wants to merge 1 commit into
base: devel
from

Conversation

@Sephtex
Copy link

commented Aug 22, 2019

SUMMARY

Adds the option to enable checksum comparison between source and destination files to make sure the destination file is updated in case the metadata didn't changed.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

win_robocopy

ADDITIONAL INFORMATION

Sometime it happens that a sourcefile has different data than the destination file, but metadata like last change time etc haven't been changed. This kind of metadata is used by robocopy to know if a file needs to be copied or not. Since robocopy doesn't have checksum checking between source and destination file, this addition when enabled on the module, will do the following before running the robocopy command:

  • gets all files from src
  • if dest file exists: checksum of both files are compared & if checksum is not equal: file is copied
  • continues to execute robocopy

Younes Ichiche
@ansibot

This comment has been minimized.

@ShachafGoldstein

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

For the specific case you mention here I would suggest using the win_copy module which has an md5 option.
Making a wrapper for robocopy to support the same options feels redundant to me.

@ansibot ansibot removed the needs_triage label Aug 22, 2019

@Sephtex

This comment has been minimized.

Copy link
Author

commented Aug 22, 2019

@ShachafGoldstein win_copy doesn't have the delete additional remote file flags, exclude files etc.. as it's not a sync module. Also win_copy is twice as slow with even the additional checksum to this win_robocopy module (when only a few files are changed).

@ansibot ansibot added the stale_ci label Aug 30, 2019

@jborean93

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2019

I'm leaning towards agreeing with @ShachafGoldstein here, this module is around robocopy operations and the PR is adding some manual checksum and copy operations because robocopy does not support this type of operation. As a middle ground is there a way to explicitly tell robocopy to include files x, y, z?

cc @nitzmahone what are your thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.