Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename checkpoint to check_point due to legal reasons, fix #61145 #61172

Merged
merged 3 commits into from Sep 3, 2019

Conversation

@liquidat
Copy link
Contributor

commented Aug 22, 2019

SUMMARY

Fixes #61145 due to legal reasons

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

network/checkpoint module path

ADDITIONAL INFORMATION

As mentioned in the issue, there are two companies out there, "checkpoint" and "Check Point". The modules here touch software of the company "Check Point", not "checkpoint", henve the need to rename the path.

As discussed with @gundalow and @thaumos this change does not brake any playbook functionality but mainly changes how the name of the company is displayed in the documentation.

@ansibot

This comment was marked as outdated.

Copy link
Contributor

commented Aug 22, 2019

@liquidat this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot

This comment was marked as outdated.

Copy link
Contributor

commented Aug 22, 2019

@liquidat, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@gundalow
Copy link
Contributor

left a comment

test/sanity/ignore.txt needs updating to point to the new directory name for checkpoint_object_facts.py

@gundalow

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

git mv test/units/modules/network/checkpoint test/units/modules/network/check_point
Also the import contained within there need updating.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

The test ansible-test sanity --test ignores [explain] failed with 1 error:

test/sanity/ignore.txt:2867:1: File 'lib/ansible/modules/network/checkpoint/checkpoint_object_facts.py' does not exist

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/network/check_point/checkpoint_object_facts.py:0:0: E337 Argument 'object_filter' in argument_spec defines type as 'str' but documentation doesn't define type
lib/ansible/modules/network/check_point/checkpoint_object_facts.py:0:0: E337 Argument 'uid' in argument_spec defines type as 'str' but documentation doesn't define type

click here for bot help

@liquidat

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

I fixed all outstanding issues, the checks have passed as well.

@liquidat

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2019

@gundalow Can you please verify if/that your requested changes were addressed?

@gundalow
Copy link
Contributor

left a comment

Looks good form a technical (ie non legal) review

@liquidat liquidat force-pushed the liquidat:fixes_61145 branch from 628f92d to 5f5221e Sep 3, 2019

@liquidat liquidat force-pushed the liquidat:fixes_61145 branch from 5f5221e to b7d1042 Sep 3, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@liquidat This PR was evaluated as a potentially problematic PR for the following reasons:

  • More than 50 changed files.

Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: #ansible-devel on irc.freenode.net

click here for bot help

liquidat added 2 commits Sep 3, 2019

@justjais justjais merged commit 9744ce1 into ansible:devel Sep 3, 2019

1 check passed

Shippable Run 141534 status is SUCCESS.
Details
justjais added a commit to justjais/ansible that referenced this pull request Sep 5, 2019
Rename checkpoint to check_point due to legal reasons, fix ansible#61145
 (ansible#61172)

* Fix ansible#61145

* Fix type keyword

* Removed file fragment

(cherry picked from commit 9744ce1)
abadger added a commit that referenced this pull request Sep 5, 2019
To fix and rename checkpoint to check_point due to legal reasons (#61872
)

* Rename checkpoint to check_point due to legal reasons, fix #61145 (#61172)

* Fix #61145

* Fix type keyword

* Removed file fragment

(cherry picked from commit 9744ce1)

* add changelogs

* adding eol

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.