Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] cloudscale: fail on invalid tags #61177

Closed
wants to merge 2 commits into from

Conversation

@resmo
Copy link
Member

commented Aug 22, 2019

SUMMARY

tags values are stored as strings by the api. if we have non-string tags and compare them, we get an "always changed" and tags are updated.

I decided to fail early instead of casting the values to strings.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cloudscale

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/cloudscale_server_group/tasks/failures.yml:7:13: colons too many spaces before colon

click here for bot help

@resmo resmo changed the title cloudscale: fail on invalid tags [WIP] cloudscale: fail on invalid tags Aug 22, 2019

@ansibot ansibot added the WIP label Aug 22, 2019

@resmo

This comment has been minimized.

Copy link
Member Author

commented Aug 26, 2019

asked the provider to implement this validation into the API, waiting for decision.

@ansibot ansibot removed the ci_verified label Aug 26, 2019

@resmo

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2019

implemented in API, closing

@resmo resmo closed this Aug 30, 2019

@resmo resmo deleted the resmo:fix/cloudscale_fail_invalid_tags branch Aug 30, 2019

@sivel sivel removed the needs_triage label Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.