Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmware_guest: don't strip hyphen from default computer name derived from vmware name #61206

Open
wants to merge 1 commit into
base: devel
from

Conversation

@pdericson
Copy link

commented Aug 23, 2019

SUMMARY

The docs say hyphen (minus) is allowed:

Allowed characters are alphanumeric (uppercase and lowercase) and minus, rest of the characters are dropped as per RFC 952.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

vmware_guest

ADDITIONAL INFORMATION

#54118

vmware_guest: don't strip hyphen from default computer name derived f…
…rom vmware name

The docs say hyphen (minus) is allowed:

Allowed characters are alphanumeric (uppercase and lowercase) and minus, rest of the characters are dropped as per RFC 952.
@ansibot

This comment has been minimized.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 23, 2019

@pdericson, just so you are aware we have a dedicated Working Group for vmware.
You can find other people interested in this in #ansible-vmware on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@goneri

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

Hi @pdericson, thanks for the contribution.

Could you add a changelog entry in changelogs/fragments?

@ansibot ansibot removed the needs_triage label Aug 26, 2019

@gundalow

This comment has been minimized.

Copy link
Contributor

commented Sep 3, 2019

@gundalow gundalow added the pr_day label Sep 3, 2019

@ansibot ansibot added the stale_ci label Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.