Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elb_target / elb_target_info : Integration test fixups #61256

Open
wants to merge 7 commits into
base: devel
from

Conversation

@tremble
Copy link
Contributor

commented Aug 24, 2019

SUMMARY

Fixups for the elb_target and elb_target_info integration tests

  • Migrate to module_defaults (and cope with not being passed security_token)
  • Finish the rename from elb_target_facts to elb_target_info
  • Lookup AMIs by name rather than a hard-coded list of AMIs
  • Update AWS policy to enable management of TargetGroups

I've bundled these into one PR because they required the same updates to hacking/aws_config/testing_policies/compute-policy.json

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/elb_target.py
lib/ansible/modules/cloud/amazon/elb_target_info.py
lib/ansible/modules/cloud/amazon/elb_target_group.py
hacking/aws_config/testing_policies/compute-policy.json

ADDITIONAL INFORMATION

@s-hertel Two more entries for #55775

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2019

cc @wimnat @yaakov-github
click here for bot help

@jillr

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

Thanks @tremble, I'm already working on the terminator classes for target groups too - those will go in mattclay/aws-terminator#47 shortly.

@jillr jillr self-assigned this Aug 29, 2019

@jillr
Copy link
Contributor

left a comment

Policies lgtm, we won't be able to re-enable the actual tests (ie; removing unsupported from the test suite alias files) until the terminator is updated but we're in merge freeze now anyway so I'll keep working on that.

@jillr

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

Test loop had a failure at:

"msg": "Failed to delete VPC vpc-04af4c6d9c612afd8 You may want to use the ec2_vpc_subnet, ec2_vpc_igw, and/or ec2_vpc_route_table modules to ensure the other components are absent.: An error occurred (DependencyViolation) when calling the DeleteVpc operation: The vpc 'vpc-04af4c6d9c612afd8' has dependencies and cannot be deleted.",

Kicking off another loop iteration to see if I come across any more failures.

@jillr jillr referenced this pull request Aug 30, 2019
@@ -1,7 +1,5 @@
---

This comment has been minimized.

Copy link
@s-hertel

s-hertel Sep 4, 2019

Contributor

Thanks for fixing this role name. When this gets merged please also backport to 2.9.

@ansibot ansibot added the stale_ci label Sep 4, 2019

@jillr jillr referenced this pull request Sep 4, 2019

@tremble tremble force-pushed the tremble:elb_target branch from 4d5c957 to 0ad06c2 Sep 7, 2019

@ansibot ansibot removed the stale_ci label Sep 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.