Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_codecommit: Fix integration tests and Add support for updating the description #61263

Merged
merged 5 commits into from Aug 30, 2019

Conversation

@tremble
Copy link
Contributor

commented Aug 24, 2019

SUMMARY
  • Fix integration tests
  • Rename 'comment' option to 'description', since that's what we're actually modifying
  • Add support for updating the description
  • Always return repository metadata when the repository exists
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/aws_codecommit.py

ADDITIONAL INFORMATION

A part of the cleanup for #55775

@tremble tremble force-pushed the tremble:aws_codecommit branch from 12242ad to 9026fab Aug 24, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 24, 2019

@tremble, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@s-hertel
Copy link
Contributor

left a comment

shipit

@caphrim007

This comment has been minimized.

Copy link
Contributor

commented Aug 30, 2019

shipit

@ansibot ansibot added shipit and removed needs_revision labels Aug 30, 2019

@jillr
jillr approved these changes Aug 30, 2019

@jillr jillr merged commit 3535995 into ansible:devel Aug 30, 2019

1 check passed

Shippable Run 141244 status is SUCCESS.
Details
adharshsrivatsr added a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
aws_codecommit: Fix integration tests and Add support for updating th…
…e description (ansible#61263)

* Update DevOps AWS policy
- Fix typos in permission names
- While AWS claims you can use 'arn:aws:codecommit:*' it errors unless you use '*'

* aws_codecommit: (integration tests) Migrate to module_defaults

* aws_codecommit: (integration tests) Fix integration tests

* aws_codecommit: (integration tests) Add tests for updating the description

* aws_codecommit: Add support for updating the description and rename "comment" option to "description"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.