Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudfront_distribution: Always add field_level_encryption_id to cache behaviour #61271

Open
wants to merge 4 commits into
base: devel
from

Conversation

@tremble
Copy link
Contributor

commented Aug 25, 2019

SUMMARY
  • Fix integration tests
  • Always add field_level_encryption_id to cache behaviour, it's now mandatory
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/cloudfront_distribution.py

ADDITIONAL INFORMATION

Run the integration tests without the final commit to see the error.

Also fixes part of #55775

@tremble tremble force-pushed the tremble:cloudfront_distribution branch from cfb66b2 to 349e74a Aug 25, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2019

@tremble, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2019

The test ansible-test sanity --test package-data [explain] failed with the error:

Command "/usr/bin/python3.6 /root/ansible/test/sanity/code-smell/package-data.py" returned exit status 1.
>>> Standard Error
Traceback (most recent call last):
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 383, in <module>
    main()
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 360, in main
    sdist_path = create_sdist(tmp_dir)
  File "/root/ansible/test/sanity/code-smell/package-data.py", line 174, in create_sdist
    raise Exception('make snapshot failed:\n%s' % stderr)
Exception: make snapshot failed:
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
fatal: not a git repository (or any parent up to mount point /)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
docs/man/man1/ansible-galaxy.1.rst:51: (WARNING/2) Definition list ends without a blank line; unexpected unindent.
docs/man/man1/ansible-galaxy.1.rst:57: (WARNING/2) Definition list ends without a blank line; unexpected unindent.
Traceback (most recent call last):
  File "packaging/release/changelogs/changelog.py", line 835, in <module>
    main()
  File "packaging/release/changelogs/changelog.py", line 102, in main
    args.func(args)
  File "packaging/release/changelogs/changelog.py", line 135, in command_release
    generate_changelog(changes, plugins, fragments)
  File "packaging/release/changelogs/changelog.py", line 288, in generate_changelog
    rst = generator.generate()
  File "packaging/release/changelogs/changelog.py", line 475, in generate
    self._add_section(builder, combined_fragments, section_name)
  File "packaging/release/changelogs/changelog.py", line 493, in _add_section
    for rst in sorted(content):
TypeError: '<' not supported between instances of 'dict' and 'str'
make: *** [changelog] Error 1

The test ansible-test sanity --test changelog [explain] failed with 1 error:

changelogs/fragments/61271-cloudfront_distribution-encryptionid.yml:0:0: section "bugfixes" list items must be type str not dict

click here for bot help

@tremble tremble force-pushed the tremble:cloudfront_distribution branch from 349e74a to 6e3530e Aug 25, 2019

@ansibot ansibot added the stale_ci label Sep 2, 2019

tremble added 3 commits Aug 25, 2019
cloudfront_distribution: (integration tests) Use the ID rather than t…
…he alias

Using aliases requires providing a valid SSL certificate, as such we're not longer able to test using an arbitrary hostname

@tremble tremble force-pushed the tremble:cloudfront_distribution branch from 6e3530e to 393995c Sep 7, 2019

cloudfront_distribution: field_level_encryption_id is now a mandatory…
… field always add it

Setting the field to an empty string has the same effect as the original behaviour.

@tremble tremble force-pushed the tremble:cloudfront_distribution branch from 393995c to 3ead881 Sep 8, 2019

@ansibot ansibot removed the stale_ci label Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.