Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/#60632] - Added get_real_file to decrypt the json file #61292

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

@hybridx
Copy link

@hybridx hybridx commented Aug 25, 2019

SUMMARY

Fixes #60632 Added get_real_file to decrypt the JSON file which was going as encrypted

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible/lib/ansible/modules/net_tools/basics

ADDITIONAL INFORMATION
https://github.com/ansible/ansible/issues/60632#issue-481119072
@ansibot
Copy link
Contributor

@ansibot ansibot commented Aug 25, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/plugins/action/uri.py:53:71: undefined-variable Undefined variable 'source'
lib/ansible/plugins/action/uri.py:53:79: undefined-variable Undefined variable 'to_text'

click here for bot help

Loading

lib/ansible/plugins/action/uri.py Show resolved Hide resolved
Loading
@ansibot
Copy link
Contributor

@ansibot ansibot commented Sep 1, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/net_tools/basics/uri.py:0:0: undocumented-parameter: Argument 'decrypt' is listed in the argument_spec, but not documented in the module documentation

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/net_tools/basics/uri.py:570:32: bad-whitespace: Exactly one space required after comma         decrypt=dict(type='bool',aliases=['decrypt']),                                 ^

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/net_tools/basics/uri.py:570:33: E231: missing whitespace after ','

click here for bot help

Loading

@ansibot
Copy link
Contributor

@ansibot ansibot commented Sep 1, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/net_tools/basics/uri.py:0:0: doc-default-does-not-match-spec: Argument 'decrypt' in argument_spec defines default as (False) but documentation defines default as (True)
lib/ansible/modules/net_tools/basics/uri.py:0:0: option-incorrect-version-added: version_added for new option (decrypt) should be '2.10'. Currently StrictVersion ('0.0')

click here for bot help

Loading

@hybridx
Copy link
Author

@hybridx hybridx commented Sep 3, 2019

@bcoca can you please review the code?

Loading

lib/ansible/modules/net_tools/basics/uri.py Outdated Show resolved Hide resolved
Loading
@hybridx hybridx requested a review from bcoca Sep 17, 2019
hybridx pushed a commit to hybridx/ansible that referenced this issue Sep 17, 2019
@hybridx hybridx requested a review from sivel Sep 17, 2019
lib/ansible/modules/net_tools/basics/uri.py Outdated Show resolved Hide resolved
Loading
@hybridx hybridx requested a review from sivel Sep 18, 2019
hybridx pushed a commit to hybridx/ansible that referenced this issue Sep 18, 2019
hybridx pushed a commit to hybridx/ansible that referenced this issue Sep 18, 2019
hybridx pushed a commit to hybridx/ansible that referenced this issue Sep 18, 2019
hybridx pushed a commit to hybridx/ansible that referenced this issue Sep 19, 2019
@ansibot
Copy link
Contributor

@ansibot ansibot commented Sep 19, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/net_tools/basics/uri.py:187:32: W291: trailing whitespace

click here for bot help

Loading

hybridx pushed a commit to hybridx/ansible that referenced this issue Sep 19, 2019
hybridx pushed a commit to hybridx/ansible that referenced this issue Sep 19, 2019
hybridx pushed a commit to hybridx/ansible that referenced this issue Sep 23, 2019
@hybridx
Copy link
Author

@hybridx hybridx commented Oct 3, 2019

Hey @sivel could you please review?

Loading

@hybridx
Copy link
Author

@hybridx hybridx commented Oct 16, 2019

@bcoca @sivel can you please review the code?

Loading

[Fix/ansible#60632] - Added get_real_file to decrypt the json file

[Ansible-uri] - Added decrypt as a parameter to uri module

[Ansible-uri] - PyLint issues resolved

[Ansible-uri] - PyLint issues resolved [2]

[T=sanity/5] - set default as True

[ansible-uri] - Setting decrypt as false -> default

[URI-Documentation] - Added documentation according to -> ansible#61292

[URI-Documentation] - Added documentation according to -> ansible#61292 - change request

[URI-Documentation] - Added documentation according to -> ansible#61292 - change request - 2

[URI-Documentation] - Added documentation according to -> ansible#61292 - change request - 3

[URI-Documentation] - Added documentation according to -> ansible#61292 - change request - 4

[URI-Documentation] - Added documentation according to -> ansible#61292 - change request - 5

[URI-Documentation] - Added documentation according to -> ansible#61292 - change request - 6

[URI-Documentation] - Added documentation according to -> ansible#61292 - change request - 7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants