Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/#60632] - Added get_real_file to decrypt the json file #61292

Open
wants to merge 7 commits into
base: devel
from

Conversation

@hybridx
Copy link

commented Aug 25, 2019

SUMMARY

Fixes #60632 Added get_real_file to decrypt the JSON file which was going as encrypted

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible/lib/ansible/modules/net_tools/basics

ADDITIONAL INFORMATION
https://github.com/ansible/ansible/issues/60632#issue-481119072
@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/plugins/action/uri.py:53:71: undefined-variable Undefined variable 'source'
lib/ansible/plugins/action/uri.py:53:79: undefined-variable Undefined variable 'to_text'

click here for bot help

@ansibot ansibot added needs_revision and removed core_review labels Aug 25, 2019

@bcoca bcoca removed the needs_triage label Aug 29, 2019

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/net_tools/basics/uri.py:0:0: undocumented-parameter: Argument 'decrypt' is listed in the argument_spec, but not documented in the module documentation

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/modules/net_tools/basics/uri.py:570:32: bad-whitespace: Exactly one space required after comma         decrypt=dict(type='bool',aliases=['decrypt']),                                 ^

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/net_tools/basics/uri.py:570:33: E231: missing whitespace after ','

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Sep 1, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 2 errors:

lib/ansible/modules/net_tools/basics/uri.py:0:0: doc-default-does-not-match-spec: Argument 'decrypt' in argument_spec defines default as (False) but documentation defines default as (True)
lib/ansible/modules/net_tools/basics/uri.py:0:0: option-incorrect-version-added: version_added for new option (decrypt) should be '2.10'. Currently StrictVersion ('0.0')

click here for bot help

Deepesh Nair added 3 commits Sep 1, 2019
@hybridx

This comment has been minimized.

Copy link
Author

commented Sep 3, 2019

@bcoca can you please review the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.