Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible_tower: Add custom_virtualenv attribute when applicable (#60200) #61323

Open
wants to merge 1 commit into
base: devel
from

Conversation

@mmallet-digipok
Copy link

commented Aug 26, 2019

SUMMARY

In Ansible Tower/AWX, there are three kinds of objects that can be tied
to custom python virtual environment:

  • job template
  • project
  • organization

This patch updates the three ansible modules that creates those objects
so that the 'custom_virtualenv' attribute can be set if specified.

Fixes #60200

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible_tower

ADDITIONAL INFORMATION

Testing Done: via a playbook, test organization, projet then template creation
without any 'custom_virtualenv' attribute specified. Check that the
resources get created and that their python env is set to default. Then
re-do the same test but this time with the 'custom_virtualenv' attribute
specified. Ensure in AWX UI that those resources have the right
'custom_virtualenv' set.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

The test ansible-test sanity --test validate-modules [explain] failed with 5 errors:

lib/ansible/modules/web_infrastructure/ansible_tower/tower_job_template.py:0:0: E309 version_added for new option (custom_virtualenv) should be '2.9'. Currently StrictVersion ('2.8')
lib/ansible/modules/web_infrastructure/ansible_tower/tower_job_template.py:0:0: E324 Argument 'custom_virtualenv' in argument_spec defines default as (None) but documentation defines default as ('None')
lib/ansible/modules/web_infrastructure/ansible_tower/tower_organization.py:0:0: E309 version_added for new option (custom_virtualenv) should be '2.9'. Currently StrictVersion ('2.8')
lib/ansible/modules/web_infrastructure/ansible_tower/tower_organization.py:0:0: E324 Argument 'custom_virtualenv' in argument_spec defines default as (None) but documentation defines default as ('None')
lib/ansible/modules/web_infrastructure/ansible_tower/tower_project.py:0:0: E324 Argument 'custom_virtualenv' in argument_spec defines default as (None) but documentation defines default as ('None')

click here for bot help

Mathieu Mallet
ansible_tower: Add custom_virtualenv attribute when applicable (#60200)
In Ansible Tower/AWX, there are three kinds of objects that can be tied
to custom python virtual environment:
  - job template
  - project
  - organization

This patch updates the three ansible modules that creates those objects
so that the 'custom_virtualenv' attribute can be set if specified.

Testing Done: via a playbook, test organization, projet then template creation
without any 'custom_virtualenv' attribute specified. Check that the
resources get created and that their python env is set to default. Then
re-do the same test but this time with the 'custom_virtualenv' attribute
specified. Ensure in AWX UI that those resources have the right
'custom_virtualenv' set.

@mmallet-digipok mmallet-digipok force-pushed the digipok:tower-add-custmom-venv-attribute branch from 3a10dc0 to 8c405d8 Aug 26, 2019

@AlanCoding

This comment has been minimized.

Copy link
Member

commented Aug 27, 2019

shipit

@ansibot ansibot removed the needs_triage label Aug 27, 2019

@ansibot ansibot added the stale_ci label Sep 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.