Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add plugin for using ec2 instance connect #61334

Open
wants to merge 3 commits into
base: devel
from

Conversation

@austburn
Copy link

commented Aug 26, 2019

SUMMARY

Allows use of newly released EC2 instance connect.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

EC2 instance connect [connection plugin] allows you to use EC2 instance connect without explicitly sending your public key.

ADDITIONAL INFORMATION

Wraps the existing SSH connection plugin, basically. It was a little difficult to track down how to use the context of both plays. I don't really love the way this looks in __init__ but if there's a better way to do this, I'd love some help driving this if this is something the community would be interested in.

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

lib/ansible/plugins/connection/ec2-instance-connect.py:65:20: bad-whitespace No space allowed around keyword argument assignment             retries = dict(max_attempts=10)                     ^
lib/ansible/plugins/connection/ec2-instance-connect.py:108:0: trailing-newlines Trailing newlines

The test ansible-test sanity --test pep8 [explain] failed with 4 errors:

lib/ansible/plugins/connection/ec2-instance-connect.py:48:1: E303 too many blank lines (3)
lib/ansible/plugins/connection/ec2-instance-connect.py:65:20: E251 unexpected spaces around keyword / parameter equals
lib/ansible/plugins/connection/ec2-instance-connect.py:65:22: E251 unexpected spaces around keyword / parameter equals
lib/ansible/plugins/connection/ec2-instance-connect.py:108:1: W391 blank line at end of file

click here for bot help

@austburn austburn force-pushed the austburn:ec2-instance-connect branch from fce0f72 to 51f5ace Aug 26, 2019

@ansibot ansibot removed the ci_verified label Aug 26, 2019

austburn added 2 commits Aug 27, 2019

@ansibot ansibot added core_review and removed needs_revision labels Aug 27, 2019

@goneri goneri added the cloud label Aug 29, 2019

@bcoca bcoca added aws and removed needs_triage labels Aug 29, 2019

@jillr

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

Hi @austburn, thanks very much for the new plugin. Could you please add tests for it?

@ansibot ansibot added the stale_ci label Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.