Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new module netapp csv pools for aws #61340

Merged
merged 6 commits into from Aug 29, 2019

Conversation

@carchi8py
Copy link
Contributor

commented Aug 26, 2019

SUMMARY

New Module: netapp CSV pools for aws

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME
  • aws_netapp_cvs_pool.py
ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

@carchi8py this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

@carchi8py, just so you are aware we have a dedicated Working Group for aws.
You can find other people interested in this in #ansible-aws on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

@carchi8py this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

The test ansible-test sanity --test future-import-boilerplate [explain] failed with 1 error:

test/units/modules/cloud/amazon/test_aws_netapp_cvs_pool.py:0:0: missing: from __future__ import (absolute_import, division, print_function)

The test ansible-test sanity --test metaclass-boilerplate [explain] failed with 1 error:

test/units/modules/cloud/amazon/test_aws_netapp_cvs_pool.py:0:0: missing: __metaclass__ = type

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_netapp_cvs_pool.py:276:1: E305 expected 2 blank lines after class or function definition, found 1

click here for bot help

assert exc.value.args[0]['msg'] is not None

@patch('ansible.modules.cloud.amazon.aws_netapp_cvs_pool.NetAppAWSCVS.get_aws_netapp_cvs_pool')
@patch('ansible.module_utils.netapp.AwsCvsRestAPI.post')

This comment has been minimized.

Copy link
@lonico

lonico Aug 27, 2019

Contributor

post needs to be changed to delete here.

@ansibot ansibot added core_review and removed needs_revision labels Aug 27, 2019

state=dict(required=True, choices=['present', 'absent']),
region=dict(required=True, type='str'),
name=dict(required=True, type='str'),
new_name=dict(required=False, type='str'),

This comment has been minimized.

Copy link
@lonico

lonico Aug 27, 2019

Contributor

don't use new_name. It should be from_name to maintain idempotency

@ansibot ansibot added needs_revision and removed core_review labels Aug 27, 2019

@lonico
lonico approved these changes Aug 28, 2019
Copy link
Contributor

left a comment

shipit

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/modules/cloud/amazon/aws_netapp_cvs_pool.py:265:1: E305 expected 2 blank lines after class or function definition, found 1

click here for bot help

@ansibot ansibot added core_review and removed needs_revision labels Aug 28, 2019

@lonico
lonico approved these changes Aug 28, 2019
Copy link
Contributor

left a comment

shipit

@anshulbehl

This comment has been minimized.

Copy link
Contributor

commented Aug 29, 2019

All looks good, shipit

@thedoubl3j
Copy link
Contributor

left a comment

everything looks good, docs fragment in plac and tests added. shipit.

@thedoubl3j thedoubl3j merged commit 9f006dd into ansible:devel Aug 29, 2019

1 check passed

Shippable Run 140614 status is SUCCESS.
Details

@sivel sivel removed the needs_triage label Aug 29, 2019

adharshsrivatsr added a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
new module netapp csv pools for aws (ansible#61340)
* new module cvs pools

* fixes

* updates

* fixes

* fixes

* fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.