Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove choices from gather_network_resources facts and fix negated all, min #61362

Merged
merged 2 commits into from Sep 4, 2019

Conversation

@trishnaguha
Copy link
Member

commented Aug 27, 2019

Signed-off-by: Trishna Guha trishnaguha17@gmail.com

SUMMARY
  • Remove choices from gather_network_resources facts and allow negating subset without needing to add a new subset specific for negation
  • !all, !min should not return any legacy facts.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/network/common/facts/facts.py

@trishnaguha trishnaguha changed the title Remove choices from gather_network_resources facts Remove choices from gather_network_resources facts and fix negated all, min Aug 27, 2019

@trishnaguha trishnaguha force-pushed the trishnaguha:network_facts_subset_choices branch from 10cdad2 to 2edc193 Aug 27, 2019

@ansibot ansibot added needs_revision and removed core_review labels Aug 27, 2019

@trishnaguha trishnaguha force-pushed the trishnaguha:network_facts_subset_choices branch 2 times, most recently from f3953b2 to c564131 Aug 27, 2019

@ansible ansible deleted a comment from ansibot Aug 27, 2019

@trishnaguha trishnaguha force-pushed the trishnaguha:network_facts_subset_choices branch from c564131 to 95f9ac2 Aug 27, 2019

@trishnaguha trishnaguha force-pushed the trishnaguha:network_facts_subset_choices branch from 95f9ac2 to c7bbbac Sep 3, 2019

@trishnaguha trishnaguha force-pushed the trishnaguha:network_facts_subset_choices branch from c7bbbac to bb28052 Sep 3, 2019

@ansibot ansibot removed the needs_rebase label Sep 3, 2019

@ansible ansible deleted a comment from ansible-zuul bot Sep 3, 2019

@trishnaguha trishnaguha force-pushed the trishnaguha:network_facts_subset_choices branch from bb28052 to 9c3011c Sep 3, 2019

@ansibot

This comment has been minimized.

@ansible ansible deleted a comment from ansibot Sep 3, 2019

@trishnaguha trishnaguha force-pushed the trishnaguha:network_facts_subset_choices branch 2 times, most recently from c56b52d to f7070b5 Sep 3, 2019

@ansible ansible deleted a comment from ansible-zuul bot Sep 4, 2019

trishnaguha added 2 commits Aug 27, 2019
remove choices from gather_network_resources facts and allow negating…
… subset without needing to add a new subset specific for negation

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
negated all, min should not return any fact
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

@trishnaguha trishnaguha force-pushed the trishnaguha:network_facts_subset_choices branch from f7070b5 to 0dcb128 Sep 4, 2019

@ansibot ansibot added core_review and removed needs_revision labels Sep 4, 2019

@ansible-zuul

This comment has been minimized.

Copy link

commented Sep 4, 2019

Build failed (third-party-check pipeline) integration testing with
Ansible.

@trishnaguha

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

Unrelated Failures.

@trishnaguha trishnaguha merged commit c1e02d5 into ansible:devel Sep 4, 2019

1 of 2 checks passed

ansible/third-party-check third-party-check status: failure
Details
Shippable Run 141729 status is SUCCESS.
Details

@trishnaguha trishnaguha deleted the trishnaguha:network_facts_subset_choices branch Sep 4, 2019

@trishnaguha

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2019

@abadger @ikhan2010 This bugfix needs to go in 2.9.

trishnaguha added a commit to trishnaguha/ansible that referenced this pull request Sep 13, 2019
Remove choices from gather_network_resources facts and fix negated al…
…l, min (ansible#61362)

* remove choices from gather_network_resources facts and allow negating subset without needing to add a new subset specific for negation

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* negated all, min should not return any fact

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
(cherry picked from commit c1e02d5)
@trishnaguha

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

Backporting PR #62260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.