Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routeros_facts: fix for error when there's more than 10 interfaces #61376

Merged
merged 3 commits into from Sep 11, 2019

Conversation

@heuels
Copy link
Contributor

commented Aug 27, 2019

SUMMARY

There's a KeyError when number of interfaces gathered from the device is more than 10. I tweaked the regular expression that is used to preprocess RouterOS output and added a regression test so that this bug does not crawl back in.

Fixes #61374.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

routeros_facts

ADDITIONAL INFORMATION

@heuels

This comment has been minimized.

Copy link
Contributor Author

commented Aug 27, 2019

ready_for_review

@ansibot

This comment has been minimized.

@heuels heuels force-pushed the heuels:routeros-61374 branch from 4673c72 to 0e8906a Aug 28, 2019

@ansibot ansibot added core_review and removed needs_revision labels Aug 28, 2019

@danielmellado danielmellado requested review from Qalthos and removed request for Qalthos Sep 4, 2019

@Qalthos
Qalthos approved these changes Sep 4, 2019

@ganeshrn ganeshrn merged commit fa03f43 into ansible:devel Sep 11, 2019

1 check passed

Shippable Run 140454 status is SUCCESS.
Details
@ganeshrn

This comment has been minimized.

Copy link
Member

commented Sep 11, 2019

@heuels For the fix to be available in 2.9 version you need to cherry-pick this PR to stable-2.9 branch.

@heuels

This comment has been minimized.

Copy link
Contributor Author

commented Sep 14, 2019

@ganeshrn, I will submit a pull request for a stable version tomorrow. Thank you for taking the time to review and merge this!

vasilyprokopov added a commit to vasilyprokopov/ansible that referenced this pull request Sep 15, 2019
routeros_facts: fix for error when there's more than 10 interfaces (a…
…nsible#61376)

* fix: proper regex for preprocessing routeros output

* test: regression test

* test: fix nondeterministic unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.