Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple_gateway module #61388

Merged
merged 3 commits into from Aug 29, 2019

Conversation

@chkp-amiads
Copy link
Contributor

commented Aug 27, 2019

SUMMARY

Checkpoint simple_gateway module

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

cp_mgmt_simple_gateway

ADDITIONAL INFORMATION

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

@chkp-amiads this PR contains more than one new module.

Please submit only one new module per pull request. For a detailed explanation, please read the grouped modules documentation

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

@chkp-amiads, just so you are aware we have a dedicated Working Group for network.
You can find other people interested in this in #ansible-network on Freenode IRC
For more information about communities, meetings and agendas see https://github.com/ansible/community

click here for bot help

@ansibot

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2019

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

lib/ansible/modules/network/checkpoint/cp_mgmt_simple_gateway.py:540:76: E127 continuation line over-indented for visual indent
lib/ansible/modules/network/checkpoint/cp_mgmt_simple_gateway.py:541:76: E128 continuation line under-indented for visual indent

click here for bot help

fix indentation issue
fails tests

@justjais justjais merged commit f687bc0 into ansible:devel Aug 29, 2019

1 check passed

Shippable Run 140601 status is SUCCESS.
Details

@sivel sivel removed the needs_triage label Aug 29, 2019

adharshsrivatsr added a commit to adharshsrivatsr/ansible that referenced this pull request Sep 3, 2019
simple_gateway module (ansible#61388)
* simple_gateway module

* list to dict

* fix indentation issue

fails tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.